-
Notifications
You must be signed in to change notification settings - Fork 994
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
Few issues:
(1) The startup log is confusing:
# Limit trie logs enabled: retention: 512; prune window: 5000 #
Some ppl mistake "prune window" for retention.
Suggest:
a) renaming "prune window" to "batch size" perhaps, also in the code as well as startup log
b) removing "prune window" ("batch size") from startup log if the default is being used (still display if explicitly set though).
(2) retention of 512 default is quite short for some use cases (< 2 hours) and may need a devnet-friendly value.
Suggest:
a) Separate option from --bonsai-historical-block-limit (but maybe still use this value as the default?)
b) Consider a new default > 512
Estimates for TRIE_LOG_STORAGE size:
| Time Period | Blocks | Size (MiB) | Size (GiB) |
| --------------- | ------ | ---------- | ----------- |
| < 2 hours | 512 | 200 | ~0.195 GiB |
| 1 day | 7,200 | 2,812.5 | ~2.75 GiB |
| 2 days | 14,400 | 5,625 | ~5.49 GiB |
| 7 days | 50,400 | 19,687.5 | ~19.23 GiB |
2 days should be sufficient for the devnet use cases.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers