Skip to content

Commit 7de1b5f

Browse files
committed
Fix docker tag issues and add note to readme
Signed-off-by: munapower <mmunaro@hotmail.com>
1 parent 36e9795 commit 7de1b5f

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

ecc/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ docker-fpc-app: docker-boilerplate-ecc
7373
exit 1;\
7474
fi
7575
echo "\033[1;33mWARNING: overriding $(DOCKER_IMAGE) docker image\033[0m"
76-
$(DOCKER) build $(DOCKER_BUILD_OPTS) -t $(DOCKER_IMAGE):$(FPC_VERSION) -f Dockerfile.fpc-app \
76+
$(DOCKER) build $(DOCKER_BUILD_OPTS) -t $(DOCKER_IMAGE):$(FPC_VERSION) -t $(DOCKER_IMAGE):latest -f Dockerfile.fpc-app \
7777
--build-arg HW_EXTENSION=$(HW_EXTENSION)\
7878
$(DOCKER_ENCLAVE_SO_PATH)
7979

samples/application/simple-cli-go/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,6 @@ DOCKER_BUILD_OPTS += --no-cache
1616
docker:
1717
$(DOCKER) build $(DOCKER_BUILD_OPTS) \
1818
-t fpc/fpcclient:$(FPC_VERSION) \
19+
-t fpc/fpcclient:latest \
1920
-f Dockerfile \
2021
.

samples/deployment/k8s/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ Note that this commands create a docker image with the name `fpc/fpcclient`.
7171
## Minikube on Mac
7272

7373
This tutorial is heavily inspired by the article [How to implement Hyperledger Fabric External Chaincodes within a Kubernetes cluster](https://medium.com/swlh/how-to-implement-hyperledger-fabric-external-chaincodes-within-a-kubernetes-cluster-fd01d7544523) by Pau Aragonès Sabaté. Thank you!
74+
Note:
75+
You might run into issues if your Mac has an M1 processor or above. If you install minikube using brew it might detect your environment as amd64 and not arm64, install the arm64 binaries. Another point is that if you have set DOCKER_DEFAULT_PLATFORM=linux/amd64 that will also generate errors. Set it in the terminal to Linux/arm64 and your minikube/docker environment should start.
7476

7577
### Start minikube
7678

0 commit comments

Comments
 (0)