Skip to content

[coordinator] Duplicate implementation in VC an Verifier manager #611

@liran-funaro

Description

@liran-funaro

The code for both managers is largely duplicated, with only minor adaptations between them.
Both managers provide the same core functionality.

This issue proposes extracting the shared logic in order to:

  • Eliminate code duplication
  • Reduce the overall code size and maintenance overhead
  • Enable bug fixes (such as [coordinator] VC manager stream end handling #608) to be implemented in a single place instead of multiple locations
  • Improve code clarity by separating management logic from service-specific logic
  • Simplify future enhancements by centralizing common behavior
  • Improve maintainability and reduce the likelihood of behavioral drift between the two managers over time

It is also worth noting that the current implementation was originally approved under time constraints.
Under normal circumstances, code with this level of duplication and mixed responsibilities would likely not be accepted as-is.

In addition, the VC manager currently has an extra responsibility: storing the shared, load-balanced VC connection.
This issue proposes moving that responsibility into a separate class, since it is unrelated to task management and violates separation of concerns.

Metadata

Metadata

Assignees

Type

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions