You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improve code clarity by separating management logic from service-specific logic
Simplify future enhancements by centralizing common behavior
Improve maintainability and reduce the likelihood of behavioral drift between the two managers over time
It is also worth noting that the current implementation was originally approved under time constraints.
Under normal circumstances, code with this level of duplication and mixed responsibilities would likely not be accepted as-is.
In addition, the VC manager currently has an extra responsibility: storing the shared, load-balanced VC connection.
This issue proposes moving that responsibility into a separate class, since it is unrelated to task management and violates separation of concerns.
The code for both managers is largely duplicated, with only minor adaptations between them.
Both managers provide the same core functionality.
This issue proposes extracting the shared logic in order to:
It is also worth noting that the current implementation was originally approved under time constraints.
Under normal circumstances, code with this level of duplication and mixed responsibilities would likely not be accepted as-is.
In addition, the VC manager currently has an extra responsibility: storing the shared, load-balanced VC connection.
This issue proposes moving that responsibility into a separate class, since it is unrelated to task management and violates separation of concerns.