fix block validation policy encoding for arma#107
Merged
tock-ibm merged 2 commits intoApr 26, 2026
Conversation
Signed-off-by: Natalie Morad <natalie.morad@ibm.com>
|
coverage: 82.378% (-0.004%) from 82.382% — moradna:fix-block-verification-policy-orderer into hyperledger:main |
liran-funaro
approved these changes
Apr 26, 2026
liran-funaro
left a comment
liran-funaro
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Only minor comments.
| Rule: MAJORITY Admins | ||
| # BlockValidation specifies what signatures must be included in the block | ||
| # from the orderer for the peer to validate it. | ||
| # For BFT-based orderers, BlockValidation is defined by the consenter set. |
Contributor
There was a problem hiding this comment.
Suggested change
| # For BFT-based orderers, BlockValidation is defined by the consenter set. | |
| # For BFT-based orderers, BlockValidation is defined automatically by the consenter set. |
| # For this end, an orderer endpoints may contain the following fields: | ||
| # - host (required) the party's host. | ||
| # - port (required) the party's post. | ||
| # - port (required) the party's port. |
| consenterProtos, err := consenterProtosFromConfig(conf.ConsenterMapping) | ||
| if err != nil { | ||
| return nil, errors.Errorf("cannot load consenter config for orderer type %s: %s", ConsensusTypeBFT, err) | ||
| return nil, errors.Errorf("cannot load consenter config for orderer type %s: %s", ConsensusTypeArma, err) |
Comment on lines
749
to
-754
| Policies: | ||
| <<: *DefaultOrdererPolicies | ||
| # We require MAJORITY for BFT. | ||
| BlockValidation: | ||
| Type: ImplicitMeta | ||
| Rule: MAJORITY Writers |
Contributor
There was a problem hiding this comment.
No need for the <<:. Can be converted to
Policies: *DefaultOrdererPoliciesSigned-off-by: Natalie Morad <natalie.morad@ibm.com>
tock-ibm
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Related issues