Restore PeerPropose ACL resource and remove ACL capability gates#115
Merged
Conversation
|
coverage: 82.683% (-0.02%) from 82.706% — cendhu:fix-acl into hyperledger:main |
cendhu
changed the title
Commit c948ab2 removed all ACL resource constants and default policy mappings, but fabric-smart-client's fabricx membership service still depends on: - resources.Peer_Propose constant ("peer/Propose") - default ACL mapping Peer_Propose → CHANNELWRITERS - aclmgmt.ACLProvider interface Changes: - core/aclmgmt/resources/resources.go: restore Peer_Propose constant - core/aclmgmt/defaultaclprovider.go: restore Peer_Propose → CHANNELWRITERS mapping - common/capabilities/application.go: ACLs() always returns true (no capability gating needed) - common/channelconfig/application.go: remove ACL capability check - Test updates for parallel test compliance -e Signed-off-by: Senthilnathan <cendhu@gmail.com>
liran-funaro
left a comment
liran-funaro
left a comment
Contributor
There was a problem hiding this comment.
We should add it back to the sample YAML file
Signed-off-by: Senthilnathan <cendhu@gmail.com>
Contributor
Author
Done. |
liran-funaro
approved these changes
May 19, 2026
liran-funaro
left a comment
liran-funaro
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I suggest @mbrandenburger testing it before merging.
mbrandenburger
approved these changes
May 19, 2026
mbrandenburger
left a comment
mbrandenburger
left a comment
Contributor
There was a problem hiding this comment.
Tested it locally and seems to work. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Commit c948ab2 removed all ACL resource constants and default policy mappings, but fabric-smart-client's fabricx membership service still depends on:
Without these, FSC fails to compile and CheckACL would hit "Unmapped policy" at runtime.
Additionally, remove the capability gate that rejected ACLs when the application capability version was below V1_2. In Fabric-X, ACLs are always allowed regardless of capability version.
Changes: