Add StreamAllTransactions to notification service API#117
Merged
Conversation
|
coverage: 82.691% (+0.03%) from 82.663% — liran-funaro:notify-new-api into hyperledger:main |
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
liran-funaro
force-pushed
the
notify-new-api
branch
from
1ea3842 to
b9f5326
Compare
cendhu
reviewed
Jun 3, 2026
cendhu
approved these changes
Jun 4, 2026
Comment on lines
+53
to
+81
|
|
||
| // StreamAllRequest is sent by clients to subscribe to all committed transactions. | ||
| message StreamAllRequest { | ||
| // Filter by namespace IDs (OR logic: transaction touches ANY of these namespaces). | ||
| // Empty list means no namespace filtering (all namespaces included). | ||
| repeated string filter_namespaces = 1; | ||
|
|
||
| // Filter by transaction status (multiple statuses can be specified). | ||
| // Empty list means no status filtering (all statuses included). | ||
| repeated Status filter_status = 2; | ||
|
|
||
| // Include transaction content (read/write sets) in the response. | ||
| // Default: false (only transaction reference and status). | ||
| bool include_read_write_sets = 3; | ||
|
|
||
| // Include endorsements in the response. | ||
| // Default: false (only transaction reference and status). | ||
| bool include_endorsements = 4; | ||
| } | ||
|
|
||
| // TxEventBatch contains a batch of transaction events from a single block. | ||
| message TxEventBatch { | ||
| // The block number from which these transactions originated. | ||
| uint64 block_number = 1; | ||
|
|
||
| // List of transaction events (may be filtered based on request). | ||
| repeated TxEvent events = 2; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe we can rename this to StreamRequest without All as we have filters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Related issues