Making the go chaincode build independent of the go fabric version

Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>

Author: pfi79

core/chaincode/platforms/golang/platform.go

@@ -26,6 +26,8 @@ import (
 	"github.com/hyperledger/fabric/internal/ccmetadata"
 	"github.com/pkg/errors"
 	"github.com/spf13/viper"
+	"golang.org/x/mod/modfile"
+	"golang.org/x/mod/semver"
 )
 
 // Platform for chaincodes written in Go
@@ -207,6 +209,7 @@ func getLDFlagsOpts() string {
 
 var buildScript = `
 set -e
+%[3]s
 if [ -f "/chaincode/input/src/go.mod" ] && [ -d "/chaincode/input/src/vendor" ]; then
     cd /chaincode/input/src
     GO111MODULE=on go build -v -mod=vendor %[1]s -o /chaincode/output/chaincode %[2]s
@@ -225,7 +228,21 @@ fi
 echo Done!
 `
 
-func (p *Platform) DockerBuildOptions(path string) (util.DockerBuildOptions, error) {
+func (p *Platform) DockerBuildOptions(path string, goVer, osVer string, archVer string) (util.DockerBuildOptions, error) {
+	// determine the presence of go.mod and the version of go in go.mod (go, toolchain)
+	var insNewGo string
+	if newGoVer, needGo := getNeedVersionGo(path, goVer); needGo {
+		// preparing the insert for the go update
+		insNewGoScript := `
+curl -sLO https://go.dev/dl/go%[1]s.%[2]s-%[3]s.tar.gz
+rm -rf /usr/local/go
+tar -C /usr/local -xzfv "go%[1]s.%[2]s-%[3]s.tar.gz"
+rm "go%[1]s.%[2]s-%[3]s.tar.gz"
+go version
+`
+		insNewGo = fmt.Sprintf(insNewGoScript, newGoVer, osVer, archVer)
+	}
+
 	env := []string{}
 	for _, key := range []string{"GOPROXY", "GOSUMDB"} {
 		if val, ok := os.LookupEnv(key); ok {
@@ -238,11 +255,54 @@ func (p *Platform) DockerBuildOptions(path string) (util.DockerBuildOptions, err
 	}
 	ldFlagOpts := getLDFlagsOpts()
 	return util.DockerBuildOptions{
-		Cmd: fmt.Sprintf(buildScript, ldFlagOpts, path),
+		Cmd: fmt.Sprintf(buildScript, ldFlagOpts, path, insNewGo),
 		Env: env,
 	}, nil
 }
 
+func getNeedVersionGo(path string, goVersion string) (string, bool) {
+	name := filepath.Join(path, "go.mod")
+	_, err := os.Stat(name)
+	if err != nil {
+		return "", false
+	}
+	data, err := os.ReadFile(name)
+	if err != nil {
+		return "", false
+	}
+
+	// get your own version of go
+	var need bool
+
+	// determine the presence of go.mod and the version of go in go.mod (go, toolchain)
+	f, err := modfile.Parse("go.mod", data, nil)
+	if err != nil {
+		return "", false
+	}
+
+	if f.Go != nil {
+		fGoVer := "v" + f.Go.Version
+		if semver.Compare(goVersion, fGoVer) == -1 {
+			goVersion = fGoVer
+			need = true
+		}
+	}
+
+	if f.Toolchain != nil {
+		fToolchaiVer := "v" + strings.TrimPrefix(f.Toolchain.Name, "go")
+		if semver.Compare(goVersion, fToolchaiVer) == -1 {
+			goVersion = fToolchaiVer
+			need = true
+		}
+	}
+
+	if need {
+		return strings.TrimPrefix(goVersion, "v"), true
+	}
+
+	return "", false
+}
+
 // CodeDescriptor describes the code we're packaging.
 type CodeDescriptor struct {
 	Source       string // absolute path of the source to package

core/chaincode/platforms/golang/platform_test.go

@@ -336,12 +336,13 @@ func TestDockerBuildOptions(t *testing.T) {
 	platform := &Platform{}
 
 	t.Run("GOPROXY and GOSUMDB not set", func(t *testing.T) {
-		opts, err := platform.DockerBuildOptions("the-path")
+		opts, err := platform.DockerBuildOptions("the-path", "", "", "")
 		require.NoError(t, err, "unexpected error from DockerBuildOptions")
 
 		expectedOpts := util.DockerBuildOptions{
 			Cmd: `
 set -e
+
 if [ -f "/chaincode/input/src/go.mod" ] && [ -d "/chaincode/input/src/vendor" ]; then
     cd /chaincode/input/src
     GO111MODULE=on go build -v -mod=vendor -ldflags "-linkmode external -extldflags '-static'" -o /chaincode/output/chaincode the-path
@@ -368,12 +369,13 @@ echo Done!
 		t.Setenv("GOPROXY", "the-goproxy")
 		t.Setenv("GOSUMDB", "the-gosumdb")
 
-		opts, err := platform.DockerBuildOptions("the-path")
+		opts, err := platform.DockerBuildOptions("the-path", "", "", "")
 		require.NoError(t, err, "unexpected error from DockerBuildOptions")
 
 		expectedOpts := util.DockerBuildOptions{
 			Cmd: `
 set -e
+
 if [ -f "/chaincode/input/src/go.mod" ] && [ -d "/chaincode/input/src/vendor" ]; then
     cd /chaincode/input/src
     GO111MODULE=on go build -v -mod=vendor -ldflags "-linkmode external -extldflags '-static'" -o /chaincode/output/chaincode the-path
@@ -395,6 +397,42 @@ echo Done!
 		}
 		require.Equal(t, expectedOpts, opts)
 	})
+
+	t.Run("Upsate version go", func(t *testing.T) {
+		opts, err := platform.DockerBuildOptions("testdata/src/chaincodes/toolchain", "v1.25.0", "linux", "arm64")
+		require.NoError(t, err, "unexpected error from DockerBuildOptions")
+
+		expectedOpts := util.DockerBuildOptions{
+			Cmd: `
+set -e
+
+curl -sLO https://go.dev/dl/go1.26.3.linux-arm64.tar.gz
+rm -rf /usr/local/go
+tar -C /usr/local -xzfv "go1.26.3.linux-arm64.tar.gz"
+rm "go1.26.3.linux-arm64.tar.gz"
+go version
+
+if [ -f "/chaincode/input/src/go.mod" ] && [ -d "/chaincode/input/src/vendor" ]; then
+    cd /chaincode/input/src
+    GO111MODULE=on go build -v -mod=vendor -ldflags "-linkmode external -extldflags '-static'" -o /chaincode/output/chaincode testdata/src/chaincodes/toolchain
+elif [ -f "/chaincode/input/src/go.mod" ]; then
+    cd /chaincode/input/src
+    GO111MODULE=on go build -v -mod=readonly -ldflags "-linkmode external -extldflags '-static'" -o /chaincode/output/chaincode testdata/src/chaincodes/toolchain
+elif [ -f "/chaincode/input/src/testdata/src/chaincodes/toolchain/go.mod" ] && [ -d "/chaincode/input/src/testdata/src/chaincodes/toolchain/vendor" ]; then
+    cd /chaincode/input/src/testdata/src/chaincodes/toolchain
+    GO111MODULE=on go build -v -mod=vendor -ldflags "-linkmode external -extldflags '-static'" -o /chaincode/output/chaincode .
+elif [ -f "/chaincode/input/src/testdata/src/chaincodes/toolchain/go.mod" ]; then
+    cd /chaincode/input/src/testdata/src/chaincodes/toolchain
+    GO111MODULE=on go build -v -mod=readonly -ldflags "-linkmode external -extldflags '-static'" -o /chaincode/output/chaincode .
+else
+    GO111MODULE=off GOPATH=/chaincode/input:$GOPATH go build -v -ldflags "-linkmode external -extldflags '-static'" -o /chaincode/output/chaincode testdata/src/chaincodes/toolchain
+fi
+echo Done!
+`,
+			Env: []string{"GOPROXY=https://proxy.golang.org"},
+		}
+		require.Equal(t, expectedOpts, opts)
+	})
 }
 
 func TestDescribeCode(t *testing.T) {
@@ -456,3 +494,17 @@ func TestMain(m *testing.M) {
 	}
 	os.Exit(m.Run())
 }
+
+func TestNeedVersionGo(t *testing.T) {
+	newGoVer, need := getNeedVersionGo("testdata/src/chaincodes/noop", "v1.26.3")
+	require.Equal(t, newGoVer, "")
+	require.False(t, need)
+
+	newGoVer, need = getNeedVersionGo("testdata/src/chaincodes/noop", "v1.12.0")
+	require.Equal(t, newGoVer, "1.13")
+	require.True(t, need)
+
+	newGoVer, need = getNeedVersionGo("testdata/src/chaincodes/toolchain", "v1.25.0")
+	require.Equal(t, newGoVer, "1.26.3")
+	require.True(t, need)
+}

core/chaincode/platforms/golang/testdata/src/chaincodes/toolchain/chaincode.go

@@ -0,0 +1,11 @@
+/*
+Copyright IBM Corp. All Rights Reserved.
+
+SPDX-License-Identifier: Apache-2.0
+*/
+
+package main
+
+func main() {
+	//  Empty shell with no dependencies
+}

core/chaincode/platforms/golang/testdata/src/chaincodes/toolchain/go.mod

@@ -0,0 +1,7 @@
+module github.com/hyperledger/fabric/core/chaincode/platforms/golang/testdata/src/chaincodes/toolchain
+
+go 1.25.10
+
+toolchain go1.26.3
+
+// This should not get included in packages that were created from a GOPATH

core/chaincode/platforms/golang/testdata/src/chaincodes/toolchain/go.sum

@@ -129,7 +129,7 @@ func (p *Platform) GenerateDockerfile() (string, error) {
 	return dockerFileContents, nil
 }
 
-func (p *Platform) DockerBuildOptions(path string) (util.DockerBuildOptions, error) {
+func (p *Platform) DockerBuildOptions(string, string, string, string) (util.DockerBuildOptions, error) {
 	return util.DockerBuildOptions{
 		Image: util.GetDockerImageFromConfig("chaincode.java.runtime"),
 		Cmd:   "./build.sh",

core/chaincode/platforms/java/platform.go

@@ -161,7 +161,7 @@ func TestGenerateDockerfile(t *testing.T) {
 func TestDockerBuildOptions(t *testing.T) {
 	platform := java.Platform{}
 
-	opts, err := platform.DockerBuildOptions("path")
+	opts, err := platform.DockerBuildOptions("path", "", "", "")
 	require.NoError(t, err, "unexpected error from DockerBuildOptions")
 
 	expectedOpts := util.DockerBuildOptions{

core/chaincode/platforms/java/platform_test.go

@@ -182,7 +182,7 @@ else
 fi
 `
 
-func (p *Platform) DockerBuildOptions(path string) (util.DockerBuildOptions, error) {
+func (p *Platform) DockerBuildOptions(string, string, string, string) (util.DockerBuildOptions, error) {
 	return util.DockerBuildOptions{
 		Image: util.GetDockerImageFromConfig("chaincode.node.runtime"),
 		Cmd:   buildScript,

core/chaincode/platforms/mock/platform.go

@@ -140,7 +140,7 @@ fi
 `
 
 func TestGenerateBuildOptions(t *testing.T) {
-	opts, err := platform.DockerBuildOptions("pathname")
+	opts, err := platform.DockerBuildOptions("pathname", "", "", "")
 	require.NoError(t, err)
 
 	expectedOpts := util.DockerBuildOptions{