Skip to content

Commit 10122f8

Browse files
authored
Merge pull request #307 from hyperledger/prioritise_docker_composev2
Prioritise docker compose v2
2 parents 9c8b5dd + 0038c76 commit 10122f8

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

.github/workflows/e2e.yml

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ jobs:
100100
- name: Run E2E tests
101101
working-directory: firefly
102102
env:
103+
DOWNLOAD_CLI: false
103104
TEST_SUITE: ${{ matrix.test-suite }}
104105
STACK_TYPE: ${{ matrix.stack-type }}
105106
BLOCKCHAIN_CONNECTOR: ${{ matrix.blockchain-connector }}

internal/docker/docker_checks.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,18 @@ func CheckDockerConfig() (DockerComposeVersion, error) {
3535
return None, fmt.Errorf("an error occurred while running docker. Is docker running on your computer?")
3636
}
3737

38-
// check for docker-compose (v1) version
39-
dockerComposeCmd := exec.Command("docker-compose", "-v")
38+
// check for docker-compose (V2) version
39+
dockerComposeCmd := exec.Command("docker", "compose", "version")
4040
_, err = dockerComposeCmd.Output()
4141
if err == nil {
42-
return ComposeV1, nil
42+
return ComposeV2, nil
4343
}
4444

45-
// check for docker-compose (V2) version
46-
dockerComposeCmd = exec.Command("docker", "compose", "version")
45+
// check for docker-compose (v1) version
46+
dockerComposeCmd = exec.Command("docker-compose", "-v")
4747
_, err = dockerComposeCmd.Output()
4848
if err == nil {
49-
return ComposeV2, nil
49+
return ComposeV1, nil
5050
}
5151

5252
return None, fmt.Errorf("an error occurred while running docker-compose. Is docker-compose installed on your computer?")

0 commit comments

Comments
 (0)