Skip to content

Commit 1cd9511

Browse files
committed
feat: remove hard-coded image names
Signed-off-by: Simon Gellis <[email protected]>
1 parent 79fed77 commit 1cd9511

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

internal/blockchain/cardano/cardanosigner/cardanosigner.go

+1-6
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,10 @@ func (p *CardanoSignerProvider) FirstTimeSetup() error {
8585
}
8686

8787
func (p *CardanoSignerProvider) GetDockerServiceDefinition(rpcURL string) *docker.ServiceDefinition {
88-
// TODO: once firefly-core is updated, remove the hard-coded default image
89-
image := "sundaeswap/firefly-cardanosigner:main"
90-
if p.stack.VersionManifest.Cardanosigner != nil {
91-
image = p.stack.VersionManifest.Cardanosigner.GetDockerImageString()
92-
}
9388
return &docker.ServiceDefinition{
9489
ServiceName: "cardanosigner",
9590
Service: &docker.Service{
96-
Image: image,
91+
Image: p.stack.VersionManifest.Cardanosigner.GetDockerImageString(),
9792
ContainerName: fmt.Sprintf("%s_cardanosigner", p.stack.Name),
9893
User: "root",
9994
Command: "./firefly-cardanosigner -f /etc/config/cardanosigner.yaml",

internal/blockchain/cardano/connector/cardanoconnect/docker.go

+1-6
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,11 @@ func (c *Cardanoconnect) GetServiceDefinitions(s *types.Stack, dependentServices
3434
extraHosts = append(extraHosts, "host.docker.internal:host-gateway")
3535
}
3636
serviceDefinitions := make([]*docker.ServiceDefinition, len(s.Members))
37-
// TODO: once firefly-core is updated, remove the hard-coded default image
38-
image := "sundaeswap/firefly-cardanoconnect:main"
39-
if s.VersionManifest.Cardanoconnect != nil {
40-
image = s.VersionManifest.Cardanoconnect.GetDockerImageString()
41-
}
4237
for i, member := range s.Members {
4338
serviceDefinitions[i] = &docker.ServiceDefinition{
4439
ServiceName: "cardanoconnect_" + member.ID,
4540
Service: &docker.Service{
46-
Image: image,
41+
Image: s.VersionManifest.Cardanoconnect.GetDockerImageString(),
4742
ContainerName: fmt.Sprintf("%s_cardanoconnect_%v", s.Name, i),
4843
Command: "./firefly-cardanoconnect -f /cardanoconnect/config/config.yaml",
4944
DependsOn: dependsOn,

0 commit comments

Comments
 (0)