Skip to content

Commit a99198d

Browse files
committed
address review comments
Signed-off-by: Chengxuan Xing <[email protected]>
1 parent a5d2902 commit a99198d

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

internal/apiclient/eventstreams.go

+5-4
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package apiclient
1818

1919
import (
2020
"context"
21+
"errors"
2122
"fmt"
2223
"regexp"
2324

@@ -31,7 +32,7 @@ func (c *fftmClient) GetEventStreams(ctx context.Context) ([]apitypes.EventStrea
3132
SetResult(&eventStreams).
3233
Get("eventstreams")
3334
if !resp.IsSuccess() {
34-
return nil, fmt.Errorf("%s", string(resp.Body()))
35+
return nil, errors.New(string(resp.Body()))
3536
}
3637
return eventStreams, err
3738
}
@@ -43,7 +44,7 @@ func (c *fftmClient) GetListeners(ctx context.Context, eventStreamID string) ([]
4344
SetResult(&listeners).
4445
Get(fmt.Sprintf("eventstreams/%s/listeners", eventStreamID))
4546
if !resp.IsSuccess() {
46-
return nil, fmt.Errorf("%s", string(resp.Body()))
47+
return nil, errors.New(string(resp.Body()))
4748
}
4849
return listeners, err
4950
}
@@ -56,7 +57,7 @@ func (c *fftmClient) DeleteEventStream(ctx context.Context, eventStreamID string
5657
return err
5758
}
5859
if !resp.IsSuccess() {
59-
return fmt.Errorf("%s", string(resp.Body()))
60+
return errors.New(string(resp.Body()))
6061
}
6162
return nil
6263
}
@@ -92,7 +93,7 @@ func (c *fftmClient) DeleteListener(ctx context.Context, eventStreamID, listener
9293
return err
9394
}
9495
if !resp.IsSuccess() {
95-
return fmt.Errorf("%s", string(resp.Body()))
96+
return errors.New(string(resp.Body()))
9697
}
9798
return nil
9899
}

internal/persistence/postgres/transaction_writer.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ func (tw *transactionWriter) assignNonces(ctx context.Context, txInsertsByFrom m
355355
}
356356
}
357357
log.L(ctx).Infof("Assigned nonce %s / %d to %s", signer, cacheEntry.nextNonce, op.txInsert.ID)
358-
//nolint:gosec // Safe conversion as nextNonce is always positive
358+
//nolint:gosec
359359
op.txInsert.Nonce = fftypes.NewFFBigInt(int64(cacheEntry.nextNonce))
360360
cacheEntry.nextNonce++
361361
tw.nextNonceCache.Add(signer, cacheEntry)

0 commit comments

Comments
 (0)