Skip to content

Commit e8fbe13

Browse files
committed
More tests update
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
1 parent 7fb6b08 commit e8fbe13

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

internal/blockchain/common/common_test.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -466,21 +466,21 @@ func TestCallbackBulkOperationUpdate(t *testing.T) {
466466
cb.SetOperationalHandler("ns1", mcb)
467467

468468
mbi.On("Name").Return("utblockchain")
469-
mcb.On("BulkOperationUpdates", mock.MatchedBy(func(updates []*core.OperationUpdate) bool {
469+
mcb.On("BulkOperationUpdates", mock.Anything, mock.MatchedBy(func(updates []*core.OperationUpdate) bool {
470470
assert.True(t, updates[0].NamespacedOpID == nsOpID &&
471471
updates[0].Status == core.OpStatusSucceeded &&
472472
updates[0].BlockchainTXID == "tx1" &&
473473
updates[0].ErrorMessage == "err" &&
474474
updates[0].Plugin == "utblockchain")
475475

476-
assert.True(t, updates[1].NamespacedOpID == nsOpID &&
476+
assert.True(t, updates[1].NamespacedOpID == nsOpID2 &&
477477
updates[1].Status == core.OpStatusSucceeded &&
478-
updates[1].BlockchainTXID == "tx1" &&
478+
updates[1].BlockchainTXID == "tx2" &&
479479
updates[1].ErrorMessage == "err" &&
480480
updates[1].Plugin == "utblockchain")
481481

482482
return true
483-
})).Return().Once()
483+
})).Return(nil).Once()
484484

485485
cb.BulkOperationUpdates(context.Background(), "ns1", []*core.OperationUpdate{
486486
{
@@ -489,13 +489,15 @@ func TestCallbackBulkOperationUpdate(t *testing.T) {
489489
BlockchainTXID: "tx1",
490490
ErrorMessage: "err",
491491
Output: fftypes.JSONObject{},
492+
Plugin: "utblockchain",
492493
},
493494
{
494495
NamespacedOpID: nsOpID2,
495496
Status: core.OpStatusSucceeded,
496497
BlockchainTXID: "tx2",
497498
ErrorMessage: "err",
498499
Output: fftypes.JSONObject{},
500+
Plugin: "utblockchain",
499501
},
500502
})
501503

internal/operations/manager_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -813,6 +813,7 @@ func TestSubmitBulkOperationUpdatesIgnoredUpdate(t *testing.T) {
813813
NamespacedOpID: "different-namespace:" + opID.String(),
814814
Status: core.OpStatusSucceeded,
815815
ErrorMessage: "my-error-message",
816+
Plugin: "blockchain",
816817
}
817818

818819
err := om.SubmitBulkOperationUpdates(ctx, []*core.OperationUpdate{submittedUpdate})
@@ -833,6 +834,7 @@ func TestSubmitBulkOperationUpdatesIgnoredBadID(t *testing.T) {
833834
NamespacedOpID: "ns1:BAD-UUID",
834835
Status: core.OpStatusSucceeded,
835836
ErrorMessage: "my-error-message",
837+
Plugin: "blockchain",
836838
}
837839

838840
err := om.SubmitBulkOperationUpdates(ctx, []*core.OperationUpdate{submittedUpdate})
@@ -863,6 +865,7 @@ func TestSubmitBulkOperationUpdatesError(t *testing.T) {
863865
NamespacedOpID: "ns1:" + opID.String(),
864866
Status: core.OpStatusSucceeded,
865867
ErrorMessage: "my-error-message",
868+
Plugin: "blockchain",
866869
}
867870

868871
mdi := om.database.(*databasemocks.Plugin)

0 commit comments

Comments
 (0)