Skip to content

Commit 31eae37

Browse files
authored
Merge pull request #1794 from WadeBarnes/ubuntu-20.04-upgrade
Fix dependency scheme
2 parents 46c9247 + 12e3ce4 commit 31eae37

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

Diff for: .github/workflows/tag.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
libgflags-dev
5656
pip install packaging \
5757
importlib_metadata==3.10.1 \
58-
indy-plenum==1.13.1rc3 \
58+
indy-plenum==1.13.1.rc3 \
5959
pyzmq==22.3.0
6060
- name: Prepare package and set version
6161
run: |

Diff for: build-scripts/ubuntu-2004/build-3rd-parties.sh

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ function build_from_pypi {
4949
SCRIPT_PATH="${BASH_SOURCE[0]}"
5050
pushd `dirname ${SCRIPT_PATH}` >/dev/null
5151

52+
build_from_pypi importlib-metadata 3.10.1
5253
build_from_pypi timeout-decorator
5354
build_from_pypi distro 1.7.0
5455

Diff for: build-scripts/ubuntu-2004/build-indy_node.sh

+5
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ cp -r "${INPUT_PATH}/." "${TMP_DIR}"
1515
cd "${TMP_DIR}/build-scripts/ubuntu-2004"
1616
./prepare-package.sh "${TMP_DIR}" indy_node "${VERSION}" debian-packages
1717

18+
echo "Fetching the indy-plenum version from setup.py and converting it to deb format ..."
19+
plenumDebVersion=$(grep -oP "indy-plenum==\d+.\d+.\d+((-|.)?rc\d+)?" ${TMP_DIR}/setup.py | grep -oP "\d+.\d+.\d+((-|.)?rc\d+)?" | sed 's/\./\~/3')
20+
echo "plenumDebVersion: ${plenumDebVersion}"
1821

1922
sed -i "s/{package_name}/${PACKAGE_NAME}/" "prerm"
2023

@@ -29,6 +32,8 @@ fpm --input-type "python" \
2932
--depends at \
3033
--depends iptables \
3134
--depends libsodium23 \
35+
--depends "indy-plenum(=${plenumDebVersion})" \
36+
--python-disable-dependency "indy-plenum" \
3237
--no-python-fix-dependencies \
3338
--maintainer "Hyperledger <[email protected]>" \
3439
--before-install "preinst_node" \

Diff for: build-scripts/ubuntu-2004/prepare-package.sh

-4
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ if [ "$distro_packages" = "debian-packages" ]; then
3333
sed -i "s~timeout-decorator~python3-timeout-decorator~" setup.py
3434
sed -i "s~distro~python3-distro~" setup.py
3535
sed -i "s~importlib-metadata=~python3-importlib-metadata=~" setup.py
36-
37-
# Only used for the deb package builds, NOT for the PyPi package builds.
38-
echo -e "\n\nPrepares indy-plenum debian package version"
39-
sed -i -r "s~indy-plenum==([0-9\.]+[0-9])(\.)?([a-z]+)~indy-plenum==\1\~\3~" setup.py
4036

4137
echo "Preparing config files"
4238
GENERAL_CONFIG_DIR="\/etc\/indy"

Diff for: setup.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@
5555
(BASE_DIR, ['data/nssm_original.exe'])
5656
)],
5757

58-
install_requires=['indy-plenum==1.13.1rc3',
58+
# Update ./build-scripts/ubuntu-xxxx/build-3rd-parties.sh when this list gets updated.
59+
# - Excluding changes to indy-plenum.
60+
install_requires=['indy-plenum==1.13.1.rc3',
5961
# importlib-metadata needs to be pinned to 3.10.1 because from v4.0.0 the package
6062
# name ends in python3-importlib-metadata_0.0.0_amd64.deb
6163
# see also build-scripts/ubuntu-2004/build-3rd-parties.sh

0 commit comments

Comments
 (0)