Skip to content

Commit 95a39b2

Browse files
meanmailclaude
andcommitted
Replace additional internal APIs with public alternatives
- CachedImageIcon.getUrl() -> Class.getResource() for icon URLs - TestStateInfo.Magnitude.getValue() -> SMTestProxy.getMagnitude() - BaseState.intIncrementModificationCount() -> incrementModificationCount() - EduMacroMap.hashCode() - add comment that it's required abstract override Reduces internal API usages from 91 to 85. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 113adb4 commit 95a39b2

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

intellij-plugin/hs-core/src/org/hyperskill/academy/learning/checker/tests/SMTestResultCollector.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ open class SMTestResultCollector : TestResultCollector() {
8383
protected fun SMTestProxy.toEduTestInfo(name: String, message: String, diff: CheckResultDiff?): EduTestInfo {
8484
return EduTestInfo(
8585
name = name,
86-
status = magnitudeInfo.value,
86+
status = magnitude,
8787
message = removeAttributes(fillWithIncorrect(message)),
8888
details = stacktrace,
8989
isFinishedSuccessfully = finishedSuccessfully(),

intellij-plugin/hs-core/src/org/hyperskill/academy/learning/courseGeneration/macro/EduMacroMap.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ package org.hyperskill.academy.learning.courseGeneration.macro
22

33
import com.intellij.openapi.components.PathMacroMap
44

5-
@Suppress("EqualsOrHashCode")
65
class EduMacroMap(private val mode: SubstitutionMode, private val macros: List<EduMacro>) : PathMacroMap() {
76

7+
// PathMacroMap.hashCode() is abstract, must override
88
override fun hashCode(): Int = macros.hashCode()
99

1010
override fun substitute(text: String, caseSensitive: Boolean): String {

intellij-plugin/hs-core/src/org/hyperskill/academy/learning/newproject/coursesStorage/CoursesStorageBase.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class UserCoursesState : BaseState() {
9393
if (courseMetaInfo != null) {
9494
courseMetaInfo.tasksSolved = tasksSolved
9595
courseMetaInfo.tasksTotal = tasksTotal
96-
intIncrementModificationCount()
96+
incrementModificationCount()
9797
}
9898
else {
9999
courses.add(JBACourseFromStorage(systemIndependentLocation, course, tasksTotal, tasksSolved))

intellij-plugin/hs-core/src/org/hyperskill/academy/learning/submissions/utils.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ import com.intellij.openapi.fileEditor.FileDocumentManager
99
import com.intellij.openapi.project.Project
1010
import com.intellij.openapi.vfs.VirtualFile
1111
import com.intellij.ui.ColorUtil
12-
import com.intellij.ui.icons.CachedImageIcon
1312
import com.intellij.util.Time
14-
import org.hyperskill.academy.EducationalCoreIcons.Submission.*
1513
import org.hyperskill.academy.learning.RemoteEnvHelper
1614
import org.hyperskill.academy.learning.courseDir
1715
import org.hyperskill.academy.learning.courseFormat.EduFormatNames.CORRECT
@@ -81,12 +79,14 @@ fun formatDate(time: Date): String {
8179
}
8280

8381
fun getImageUrl(status: String?): URL? {
84-
val icon = when (status) {
85-
CORRECT -> if (StyleResourcesManager.isHighContrast()) TaskSolvedHighContrast else TaskSolved
86-
else -> if (StyleResourcesManager.isHighContrast()) TaskFailedHighContrast else TaskFailed
87-
}
82+
val iconPath = when (status) {
83+
CORRECT -> if (StyleResourcesManager.isHighContrast()) "/icons/org/hyperskill/academy/submission/taskSolvedHighContrast@2x.png"
84+
else "/icons/org/hyperskill/academy/submission/taskSolved@2x.png"
8885

89-
return (icon as CachedImageIcon).url
86+
else -> if (StyleResourcesManager.isHighContrast()) "/icons/org/hyperskill/academy/submission/taskFailedHighContrast@2x.png"
87+
else "/icons/org/hyperskill/academy/submission/taskFailed@2x.png"
88+
}
89+
return Submission::class.java.getResource(iconPath)
9090
}
9191

9292
fun getLinkColor(submission: Submission): String {

0 commit comments

Comments
 (0)