Skip to content

bug: logging to file resets lazy_load_blob #108

Description

@nick1udwig

Describe the bug
https://discord.com/channels/1186394868336038080/1306250401451999253

If you receive an HTTP request and log it (e.g. info!(); sending to println!() is fine) before reading the body with get_blob(), logging it to file will have replaced the blob. This happens because we Append to the log file, receiving a Result back from vfs, and hence, replacing our lazy_load_blob with None.

Code trace:

  1. The file logger .append() call
  2. What that .append() call does under the hood: Append and handle Response from vfs
  3. lazy_load_blobs are thrown out when a new message is received

Expected behavior
Logging should not alter lazy_load_blob.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions