fix: don't retry broadcast

Retrying a broadcast can result in sending multiple broadcast messages
to a worker because we don't differntiate between succesful sends and
not. We shouldn't do a retry here. Instead the retries on getting a
connection to a worker have been increased. In the future, we should
handle the retry from the scheduler.

Author: l45k

crates/worker/src/executor/parameter_server.rs

@@ -340,18 +340,12 @@ impl JobExecutor for ParameterServerExecutor {
                                     }
                                 };
 
-                                match Retry::spawn(retry_strategy.clone(), || {
-                                    let connector = connector.clone();
-                                    let send = send.clone();
-                                    let cancel = cancel.clone();
-                                    async move { broadcast_update(
+                                match broadcast_update(
                                     connector.clone(),
                                     send,
                                     gradient_file,
-                                    cancel.clone(),
+                                    cancel.clone()
                                 ).await
-                                    }
-                                }).await
                                 {
                                     Ok(()) => {
                                         pending_update = None;