From ef4c49f15e1d389821d21db25554ac085c75a8ac Mon Sep 17 00:00:00 2001 From: wjsoj Date: Thu, 5 Nov 2026 08:08:47 -0800 Subject: [PATCH 1/2] fix(provider-html-local): answer only the capture server's own loopback host The rendering server bound to 127.0.0.1 but served any Host header, so a web page that rebinds its own name to 127.0.0.1 could read staged program HTML, media and decoded frames while a render ran. Reply 421 unless the request addresses the server by the URL it handed to Chrome. --- packages/provider-html-local/src/server.ts | 5 +++ .../provider-html-local/test/server.test.ts | 33 +++++++++++++++++++ 2 files changed, 38 insertions(+) create mode 100644 packages/provider-html-local/test/server.test.ts diff --git a/packages/provider-html-local/src/server.ts b/packages/provider-html-local/src/server.ts index 753edce4c..2d9decb64 100644 --- a/packages/provider-html-local/src/server.ts +++ b/packages/provider-html-local/src/server.ts @@ -13,8 +13,12 @@ const mediaTypes: Readonly> = { /** Serve one staged program and its lazily decoded frames to local capture pages. */ export async function serveHtmlProgram(root: string): Promise<{ readonly url: string; close(): Promise }> { const base = resolve(root); + let origin: string | undefined; const server = createServer(async (request, response) => { try { + // Only the capture page addresses this server, always by its loopback URL. + // A page reaching it through another name (DNS rebinding) is refused. + if (request.headers.host !== origin) { response.writeHead(421).end(); return; } const pathname = decodeURIComponent(new URL(request.url ?? "/", "http://127.0.0.1").pathname); const path = resolve(base, pathname === "/" ? "index.html" : `.${pathname}`); if (path !== base && !path.startsWith(`${base}${sep}`)) { @@ -45,6 +49,7 @@ export async function serveHtmlProgram(root: string): Promise<{ readonly url: st }); const address = server.address(); if (address === null || typeof address === "string") throw new Error("HTML Program server did not bind a TCP port"); + origin = `127.0.0.1:${address.port}`; return { url: `http://127.0.0.1:${address.port}/`, close: () => new Promise((resolveClose, reject) => server.close(error => error ? reject(error) : resolveClose())), diff --git a/packages/provider-html-local/test/server.test.ts b/packages/provider-html-local/test/server.test.ts new file mode 100644 index 000000000..e2cb40edb --- /dev/null +++ b/packages/provider-html-local/test/server.test.ts @@ -0,0 +1,33 @@ +import assert from "node:assert/strict"; +import { request } from "node:http"; +import test from "node:test"; +import { mkdtemp, rm, writeFile } from "node:fs/promises"; +import { tmpdir } from "node:os"; +import { join } from "node:path"; +import { serveHtmlProgram } from "../src/server.js"; + +function get(url: string, host?: string): Promise { + return new Promise((resolveStatus, reject) => { + const target = new URL(url); + const outgoing = request({ hostname: target.hostname, port: target.port, path: target.pathname, + headers: host === undefined ? {} : { host } }, (response) => { + response.resume(); + response.on("end", () => resolveStatus(response.statusCode ?? 0)); + }); + outgoing.on("error", reject); + outgoing.end(); + }); +} + +test("the capture server answers only its own loopback host, so a rebound name cannot read staged material", async (t) => { + const root = await mkdtemp(join(tmpdir(), "hypit-html-server-")); + t.after(() => rm(root, { recursive: true, force: true })); + await writeFile(join(root, "index.html"), "

program

"); + const server = await serveHtmlProgram(root); + t.after(() => server.close()); + const { host } = new URL(server.url); + assert.equal(await get(server.url), 200); + assert.equal(await get(server.url, host), 200); + assert.equal(await get(server.url, `attacker.example:${new URL(server.url).port}`), 421); + assert.equal(await get(server.url, "localhost"), 421); +}); From 494cd0dd33194ce482629f033a3459f601894c40 Mon Sep 17 00:00:00 2001 From: wjsoj Date: Thu, 5 Nov 2026 08:39:11 -0800 Subject: [PATCH 2/2] test(provider-html-local): reject localhost with the capture port as Host A name that resolves to loopback but is not the server's own host, with or without the port, must still get 421. --- packages/provider-html-local/test/server.test.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/provider-html-local/test/server.test.ts b/packages/provider-html-local/test/server.test.ts index e2cb40edb..82f9c3601 100644 --- a/packages/provider-html-local/test/server.test.ts +++ b/packages/provider-html-local/test/server.test.ts @@ -1,7 +1,7 @@ import assert from "node:assert/strict"; -import { request } from "node:http"; import test from "node:test"; import { mkdtemp, rm, writeFile } from "node:fs/promises"; +import { request } from "node:http"; import { tmpdir } from "node:os"; import { join } from "node:path"; import { serveHtmlProgram } from "../src/server.js"; @@ -25,9 +25,10 @@ test("the capture server answers only its own loopback host, so a rebound name c await writeFile(join(root, "index.html"), "

program

"); const server = await serveHtmlProgram(root); t.after(() => server.close()); - const { host } = new URL(server.url); + const { host, port } = new URL(server.url); assert.equal(await get(server.url), 200); assert.equal(await get(server.url, host), 200); - assert.equal(await get(server.url, `attacker.example:${new URL(server.url).port}`), 421); + assert.equal(await get(server.url, `attacker.example:${port}`), 421); + assert.equal(await get(server.url, `localhost:${port}`), 421); assert.equal(await get(server.url, "localhost"), 421); });