fix(ctrl+k behaviour): should trigger shortcuts while in text input

Author: Elimpizza

src/sidebar/components/search/SearchIconButton.tsx

@@ -34,8 +34,10 @@ function useSearchKeyboardShortcuts(store: SidebarStore) {
 
   const modifierKey = isMacOS() ? 'meta' : 'ctrl';
 
+  // When user is in an input field, respond to CMD-/CTRL-K keypresses,
+  // but ignore '/' keypresses
   useShortcut(shortcuts.openSearch, openSearch, { ignoreWhenEditable: true });
-  useShortcut(`${modifierKey}+k`, openSearch, { ignoreWhenEditable: true });
+  useShortcut(`${modifierKey}+k`, openSearch, { ignoreWhenEditable: false });
 }
 
 export default function SearchIconButton() {

src/sidebar/components/search/test/SearchIconButton-test.js

@@ -199,7 +199,7 @@ describe('SearchIconButton', () => {
       });
     });
 
-    it('does not open search panel if user is in an input field and presses "Ctrl-k"', () => {
+    it('opens search panel if user is in an input field and presses "Ctrl-k"', () => {
       fakeIsMacOS.returns(false);
       const input = document.createElement('input');
       document.body.append(input);
@@ -220,7 +220,7 @@ describe('SearchIconButton', () => {
           }),
         );
 
-        assert.notCalled(fakeStore.openSidebarPanel);
+        assert.calledWith(fakeStore.openSidebarPanel, 'searchAnnotations');
       } finally {
         input.remove();
       }