Skip to content

Commit c369394

Browse files
authored
Upgrade python patch versions and drop 3.8 (#46)
1 parent 43bc442 commit c369394

File tree

8 files changed

+13
-24
lines changed

8 files changed

+13
-24
lines changed

.cookiecutter/cookiecutter.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"package_name": "h_assets",
1212
"slug": "h-assets",
1313
"short_description": "Pyramid views for serving collections of compiled static assets (eg. bundles of JavaScript and CSS).",
14-
"python_versions": "3.12.4, 3.11.9, 3.10.14, 3.9.19, 3.8.19",
14+
"python_versions": "3.12.7, 3.11.10, 3.10.15, 3.9.20",
1515
"github_owner": "hypothesis",
1616
"copyright_holder": "Hypothesis",
1717
"visibility": "public",

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
runs-on: ubuntu-latest
5050
strategy:
5151
matrix:
52-
python-version: ['3.12', '3.11', '3.10', '3.9', '3.8']
52+
python-version: ['3.12', '3.11', '3.10', '3.9']
5353
name: Unit tests with Python ${{ matrix.python-version }}
5454
steps:
5555
- uses: actions/checkout@v3
@@ -87,7 +87,7 @@ jobs:
8787
runs-on: ubuntu-latest
8888
strategy:
8989
matrix:
90-
python-version: ['3.12', '3.11', '3.10', '3.9', '3.8']
90+
python-version: ['3.12', '3.11', '3.10', '3.9']
9191
name: Functional tests with Python ${{ matrix.python-version }}
9292
steps:
9393
- uses: actions/checkout@v3

.python-version

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
3.12.4
2-
3.11.9
3-
3.10.14
4-
3.9.19
5-
3.8.19
1+
3.12.7
2+
3.11.10
3+
3.10.15
4+
3.9.20

Makefile

+2-12
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,10 @@ $(call help,make test-py39,"run the unit tests in Python 3.9")
5353
test-py39: python
5454
@pyenv exec tox -qe py39-tests
5555

56-
.PHONY: test-py38
57-
$(call help,make test-py38,"run the unit tests in Python 3.8")
58-
test-py38: python
59-
@pyenv exec tox -qe py38-tests
60-
6156
.PHONY: coverage
6257
$(call help,make coverage,"run the tests and print the coverage report")
6358
coverage: python
64-
@pyenv exec tox --parallel -qe 'tests,py{311,310,39,38}-tests,coverage'
59+
@pyenv exec tox --parallel -qe 'tests,py{311,310,39}-tests,coverage'
6560

6661
.PHONY: functests
6762
$(call help,make functests,"run the functional tests in Python 3.12")
@@ -83,16 +78,11 @@ $(call help,make functests-py39,"run the functional tests in Python 3.9")
8378
functests-py39: python
8479
@pyenv exec tox -qe py39-functests
8580

86-
.PHONY: functests-py38
87-
$(call help,make functests-py38,"run the functional tests in Python 3.8")
88-
functests-py38: python
89-
@pyenv exec tox -qe py38-functests
90-
9181
.PHONY: sure
9282
$(call help,make sure,"make sure that the formatting$(comma) linting and tests all pass")
9383
sure: python
9484
sure:
95-
@pyenv exec tox --parallel -qe 'checkformatting,lint,typecheck,tests,py{311,310,39,38}-tests,coverage,functests,py{311,310,39,38}-functests'
85+
@pyenv exec tox --parallel -qe 'checkformatting,lint,typecheck,tests,py{311,310,39}-tests,coverage,functests,py{311,310,39}-functests'
9686

9787
.PHONY: template
9888
$(call help,make template,"update from the latest cookiecutter template")

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<a href="https://github.com/hypothesis/h-assets/actions/workflows/ci.yml?query=branch%3Amain"><img src="https://img.shields.io/github/actions/workflow/status/hypothesis/h-assets/ci.yml?branch=main"></a>
22
<a href="https://pypi.org/project/h-assets"><img src="https://img.shields.io/pypi/v/h-assets"></a>
3-
<a><img src="https://img.shields.io/badge/python-3.12 | 3.11 | 3.10 | 3.9 | 3.8-success"></a>
3+
<a><img src="https://img.shields.io/badge/python-3.12 | 3.11 | 3.10 | 3.9-success"></a>
44
<a href="https://github.com/hypothesis/h-assets/blob/main/LICENSE"><img src="https://img.shields.io/badge/license-BSD--2--Clause-success"></a>
55
<a href="https://github.com/hypothesis/cookiecutters/tree/main/pypackage"><img src="https://img.shields.io/badge/cookiecutter-pypackage-success"></a>
66
<a href="https://black.readthedocs.io/en/stable/"><img src="https://img.shields.io/badge/code%20style-black-000000"></a>

bin/make_python

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ if [ -n "${CI+x}" ]; then exit; fi
88

99
pyenv_root=$(pyenv root)
1010

11-
for python_version in 3.12.4 3.11.9 3.10.14 3.9.19 3.8.19; do
11+
for python_version in 3.12.7 3.11.10 3.10.15 3.9.20; do
1212
bin_dir=$pyenv_root/versions/$python_version/bin
1313
if [ ! -f "$bin_dir"/tox ]; then
1414
pyenv install --skip-existing "$python_version"

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ classifiers = [
1212
"License :: OSI Approved :: BSD License",
1313
"Intended Audience :: Developers",
1414
]
15-
requires-python = ">=3.8"
15+
requires-python = ">=3.9"
1616
dependencies = [
1717
"pyramid",
1818
]

tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ deps =
4444
lint,template: cookiecutter
4545
typecheck: mypy
4646
depends =
47-
coverage: tests,py{311,310,39,38}-tests
47+
coverage: tests,py{311,310,39}-tests
4848
commands =
4949
dev: {posargs:ipython --classic --no-banner --no-confirm-exit}
5050
format: black src tests bin

0 commit comments

Comments
 (0)