Skip to content

Commit 601b019

Browse files
moetayukomoetayuko
committed
xwayland: support HiDPI scale
This supports the xorg-xwayland patch at https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/733 Ported from https://gitlab.freedesktop.org/lilydjwg/wlroots/-/commit/5a7c65cab11c9f3c3dc79f9c4cfb8a6acf6cbaae
1 parent 22b12e3 commit 601b019

File tree

5 files changed

+59
-14
lines changed

5 files changed

+59
-14
lines changed

‎src/protocols/PointerConstraints.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#include "../managers/input/InputManager.hpp"
88
#include "../render/Renderer.hpp"
99
#include "../helpers/Monitor.hpp"
10+
#include "../xwayland/XWayland.hpp"
1011

1112
CPointerConstraint::CPointerConstraint(SP<CZwpLockedPointerV1> resource_, SP<CWLSurfaceResource> surf, wl_resource* region_, zwpPointerConstraintsV1Lifetime lifetime_) :
1213
m_resourceLocked(resource_), m_locked(true), m_lifetime(lifetime_) {
@@ -37,7 +38,7 @@ CPointerConstraint::CPointerConstraint(SP<CZwpLockedPointerV1> resource_, SP<CWL
3738
const auto PWINDOW = m_hlSurface->getWindow();
3839
if (PWINDOW) {
3940
const auto ISXWL = PWINDOW->m_isX11;
40-
scale = ISXWL && *PXWLFORCESCALEZERO ? PWINDOW->m_X11SurfaceScaledBy : 1.f;
41+
scale = ISXWL ? (*PXWLFORCESCALEZERO ? PWINDOW->m_X11SurfaceScaledBy : g_pXWayland->m_wm->getScale()) : 1.f;
4142
}
4243

4344
m_positionHint = {wl_fixed_to_double(x) / scale, wl_fixed_to_double(y) / scale};

‎src/xwayland/XSurface.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,8 @@ void CXWaylandSurface::configure(const CBox& box) {
168168
m_geometry = box;
169169

170170
uint32_t mask = XCB_CONFIG_WINDOW_X | XCB_CONFIG_WINDOW_Y | XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT | XCB_CONFIG_WINDOW_BORDER_WIDTH;
171-
uint32_t values[] = {box.x, box.y, box.width, box.height, 0};
171+
uint32_t values[] = {g_pXWayland->m_wm->applyScale(box.x), g_pXWayland->m_wm->applyScale(box.y), g_pXWayland->m_wm->applyScale(box.width),
172+
g_pXWayland->m_wm->applyScale(box.height), 0};
172173
xcb_configure_window(g_pXWayland->m_wm->m_connection, m_xID, mask, values);
173174

174175
if (m_geometry.width == box.width && m_geometry.height == box.height) {
@@ -177,10 +178,10 @@ void CXWaylandSurface::configure(const CBox& box) {
177178
e.response_type = XCB_CONFIGURE_NOTIFY;
178179
e.event = m_xID;
179180
e.window = m_xID;
180-
e.x = box.x;
181-
e.y = box.y;
182-
e.width = box.width;
183-
e.height = box.height;
181+
e.x = g_pXWayland->m_wm->applyScale(box.x);
182+
e.y = g_pXWayland->m_wm->applyScale(box.y);
183+
e.width = g_pXWayland->m_wm->applyScale(box.width);
184+
e.height = g_pXWayland->m_wm->applyScale(box.height);
184185
e.border_width = 0;
185186
e.above_sibling = XCB_NONE;
186187
e.override_redirect = m_overrideRedirect;

‎src/xwayland/XWM.cpp

Lines changed: 45 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,9 @@ void CXWM::handleCreate(xcb_create_notify_event_t* e) {
4040
if (isWMWindow(e->window))
4141
return;
4242

43-
const auto XSURF = m_surfaces.emplace_back(SP<CXWaylandSurface>(new CXWaylandSurface(e->window, CBox{e->x, e->y, e->width, e->height}, e->override_redirect)));
44-
XSURF->m_self = XSURF;
43+
const auto XSURF = m_surfaces.emplace_back(
44+
SP<CXWaylandSurface>(new CXWaylandSurface(e->window, CBox{applyUnScale(e->x), applyUnScale(e->y), applyUnScale(e->width), applyUnScale(e->height)}, e->override_redirect)));
45+
XSURF->m_self = XSURF;
4546
Debug::log(LOG, "[xwm] New XSurface at {:x} with xid of {}", (uintptr_t)XSURF.get(), e->window);
4647

4748
const auto WINDOW = CWindow::create(XSURF);
@@ -71,9 +72,9 @@ void CXWM::handleConfigureRequest(xcb_configure_request_event_t* e) {
7172
if (!(MASK & GEOMETRY))
7273
return;
7374

74-
XSURF->m_events.configureRequest.emit(CBox{MASK & XCB_CONFIG_WINDOW_X ? e->x : XSURF->m_geometry.x, MASK & XCB_CONFIG_WINDOW_Y ? e->y : XSURF->m_geometry.y,
75-
MASK & XCB_CONFIG_WINDOW_WIDTH ? e->width : XSURF->m_geometry.width,
76-
MASK & XCB_CONFIG_WINDOW_HEIGHT ? e->height : XSURF->m_geometry.height});
75+
XSURF->m_events.configureRequest.emit(CBox{
76+
MASK & XCB_CONFIG_WINDOW_X ? applyUnScale(e->x) : XSURF->m_geometry.x, MASK & XCB_CONFIG_WINDOW_Y ? applyUnScale(e->y) : XSURF->m_geometry.y,
77+
MASK & XCB_CONFIG_WINDOW_WIDTH ? applyUnScale(e->width) : XSURF->m_geometry.width, MASK & XCB_CONFIG_WINDOW_HEIGHT ? applyUnScale(e->height) : XSURF->m_geometry.height});
7778
}
7879

7980
void CXWM::handleConfigureNotify(xcb_configure_notify_event_t* e) {
@@ -82,10 +83,11 @@ void CXWM::handleConfigureNotify(xcb_configure_notify_event_t* e) {
8283
if (!XSURF)
8384
return;
8485

85-
if (XSURF->m_geometry == CBox{e->x, e->y, e->width, e->height})
86+
const auto GEOM = CBox{applyUnScale(e->x), applyUnScale(e->y), applyUnScale(e->width), applyUnScale(e->height)};
87+
if (XSURF->m_geometry == GEOM)
8688
return;
8789

88-
XSURF->m_geometry = {e->x, e->y, e->width, e->height};
90+
XSURF->m_geometry = GEOM;
8991
updateOverrideRedirect(XSURF, e->override_redirect);
9092
XSURF->m_events.setGeometry.emit();
9193
}
@@ -263,6 +265,17 @@ void CXWM::readProp(SP<CXWaylandSurface> XSURF, uint32_t atom, xcb_get_property_
263265

264266
xcb_icccm_get_wm_size_hints_from_reply(XSURF->m_sizeHints.get(), reply);
265267

268+
XSURF->m_sizeHints->x = applyUnScale(XSURF->m_sizeHints->x);
269+
XSURF->m_sizeHints->y = applyUnScale(XSURF->m_sizeHints->y);
270+
XSURF->m_sizeHints->width = applyUnScale(XSURF->m_sizeHints->width);
271+
XSURF->m_sizeHints->height = applyUnScale(XSURF->m_sizeHints->height);
272+
XSURF->m_sizeHints->min_width = applyUnScale(XSURF->m_sizeHints->min_width);
273+
XSURF->m_sizeHints->min_height = applyUnScale(XSURF->m_sizeHints->min_height);
274+
XSURF->m_sizeHints->max_width = applyUnScale(XSURF->m_sizeHints->max_width);
275+
XSURF->m_sizeHints->max_height = applyUnScale(XSURF->m_sizeHints->max_height);
276+
XSURF->m_sizeHints->base_width = applyUnScale(XSURF->m_sizeHints->base_width);
277+
XSURF->m_sizeHints->base_height = applyUnScale(XSURF->m_sizeHints->base_height);
278+
266279
const int32_t FLAGS = XSURF->m_sizeHints->flags;
267280
const bool HASMIN = (FLAGS & XCB_ICCCM_SIZE_HINT_P_MIN_SIZE);
268281
const bool HASBASE = (FLAGS & XCB_ICCCM_SIZE_HINT_BASE_SIZE);
@@ -306,8 +319,20 @@ void CXWM::readProp(SP<CXWaylandSurface> XSURF, uint32_t atom, xcb_get_property_
306319
void CXWM::handlePropertyNotify(xcb_property_notify_event_t* e) {
307320
const auto XSURF = windowForXID(e->window);
308321

309-
if (!XSURF)
322+
if (!XSURF) {
323+
if (e->atom == HYPRATOMS["_XWAYLAND_GLOBAL_OUTPUT_SCALE"]) {
324+
xcb_get_property_cookie_t cookie = xcb_get_property(m_connection, 0, e->window, e->atom, XCB_ATOM_ANY, 0, 2048);
325+
xcb_get_property_reply_t* reply = xcb_get_property_reply(m_connection, cookie, nullptr);
326+
if (!reply) {
327+
return;
328+
}
329+
if (reply->type == XCB_ATOM_CARDINAL) {
330+
m_scale = *(uint32_t*)xcb_get_property_value(reply);
331+
}
332+
free(reply);
333+
}
310334
return;
335+
}
311336

312337
xcb_get_property_cookie_t cookie = xcb_get_property(m_connection, 0, XSURF->m_xID, e->atom, XCB_ATOM_ANY, 0, 2048);
313338
xcb_get_property_reply_t* reply = xcb_get_property_reply(m_connection, cookie, nullptr);
@@ -1331,6 +1356,18 @@ SP<IDataOffer> CXWM::createX11DataOffer(SP<CWLSurfaceResource> surf, SP<IDataSou
13311356
return offer;
13321357
}
13331358

1359+
double CXWM::getScale() {
1360+
return m_scale;
1361+
}
1362+
1363+
double CXWM::applyScale(double val) {
1364+
return std::floor(val * m_scale);
1365+
}
1366+
1367+
double CXWM::applyUnScale(double val) {
1368+
return std::ceil(val / m_scale);
1369+
}
1370+
13341371
void SXSelection::onSelection() {
13351372
if ((this == &g_pXWayland->m_wm->m_clipboard && g_pSeatManager->m_selection.currentSelection && g_pSeatManager->m_selection.currentSelection->type() == DATA_SOURCE_TYPE_X11) ||
13361373
(this == &g_pXWayland->m_wm->m_primarySelection && g_pSeatManager->m_selection.currentPrimarySelection &&

‎src/xwayland/XWM.hpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ class CXWM {
112112
int onEvent(int fd, uint32_t mask);
113113
SP<CX11DataDevice> getDataDevice();
114114
SP<IDataOffer> createX11DataOffer(SP<CWLSurfaceResource> surf, SP<IDataSource> source);
115+
double getScale();
115116

116117
private:
117118
void setCursor(unsigned char* pixData, uint32_t stride, const Vector2D& size, const Vector2D& hotspot);
@@ -173,12 +174,16 @@ class CXWM {
173174

174175
SXSelection* getSelection(xcb_atom_t atom);
175176

177+
double applyScale(double val);
178+
double applyUnScale(double val);
179+
176180
//
177181
CXCBConnection m_connection;
178182
xcb_errors_context_t* m_errors = nullptr;
179183
xcb_screen_t* m_screen = nullptr;
180184

181185
xcb_window_t m_wmWindow;
186+
double m_scale = 1.0;
182187

183188
wl_event_source* m_eventSource = nullptr;
184189

‎src/xwayland/XWayland.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,5 +127,6 @@ inline std::unordered_map<std::string, uint32_t> HYPRATOMS = {
127127
HYPRATOM("DELETE"),
128128
HYPRATOM("TEXT"),
129129
HYPRATOM("INCR"),
130+
HYPRATOM("_XWAYLAND_GLOBAL_OUTPUT_SCALE"),
130131
#endif
131132
};

0 commit comments

Comments
 (0)