Hyprctl dispatch - resize params negative values crashes command

[LuukBlankenstijn]

Hey, I am using Hyprctl for a project of mine, and I ran into the following bug.

Problem

When i try to use

hyprctl dispatch movewindowpixel -10 -10, class:firefox

this does not complete succesfully. However, when using

hyprctl dispatch movewindowpixel -10 10, class:firefox

it does work.

I looked into the source code, and discovered that in hyprctl/main.cpp on line 363,
if (parseArgs && (ARGS[i][0] == '-') && !isNumber(ARGS[i], true) /* For stuff like -2 */), lies the problem. Because of the comma right after the second coordinate, ARGS[i] is -10,. This has as a consequence that isNumber(ARGS[i], true) returns false and -10, is treated as an option. The option 10, does not exist, and the command does not complete successfully.

Solution

As a solution I thought of skipping parsing after ARGS[i] is "dispatch". However, this seems too aggressive, and does not actually solve the bug. I would love to hear opinions on what is the best way to solve it, and I will make a pull-request with the solution.

Note

I found out that using

hyprctl dispatch -- movewindowpixel -10 -10, class:firefox

does work. This is to be expected, since with this all arguments after -- are not being parsed and just passed on directly.

[gfhdhytghd]

I have a similar issue,

hyprctl dispatch movewindowpixel "500 0","class:^(GPT)$"  

works,
but

hyprctl dispatch movewindowpixel "-500 0","class:^(GPT)$"  

doesn't work.

use -- do solve

[LuukBlankenstijn]

Yeah, when using the quotes, both coordinates are treated as one arg. When x is then negative, there is the same problem of treating -500 0, as an option. If the bug I found in the code is fixed, you could just leave out the quotes and everything should work.

[LuukBlankenstijn]

I created #10671 with a fix.