hyprland-source/hyprpm/src/core/PluginManager.cpp: 8 * ineffective calls to substr ?

[dcb314]

Static analyser cppcheck says:

hyprland-source/hyprpm/src/core/PluginManager.cpp:103:21: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
hyprland-source/hyprpm/src/core/PluginManager.cpp:440:24: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
hyprland-source/hyprpm/src/core/PluginManager.cpp:442:24: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
hyprland-source/hyprpm/src/core/PluginManager.cpp:555:31: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
hyprland-source/hyprpm/src/core/PluginManager.cpp:556:31: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
hyprland-source/hyprpm/src/core/PluginManager.cpp:91:28: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
hyprland-source/hyprpm/src/core/PluginManager.cpp:94:28: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
hyprland-source/hyprpm/src/core/PluginManager.cpp:97:26: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr]
hyprland $

Might be worth fixing.

[ItsOhen]

Lmao. Really? Is a single allocation really that bad? Or is it worth it to keep it for readability?
If you do as the analyzer say you have to make sure that resize actually gets a value. Blindly replacing it with resize would make it go boom if find come back empty.

[dcb314]

Cppcheck reported 137 performance problems. I sampled some of them.
If you aren't bothered about fixing them, then fair enough.

[vaxerski]

I mean yeah could be fixed, feel free to submit a MR, but these aren't in any hot paths so it doesn't matter that much.