Native Wayland + OpenGL RetroArch black screenshots with DS

[fxzzi]

As title explains, DS on retroarch seems to work, but I'm unable to take screenshots as the image comes out black. The screen flickers when i press my prtscr

It doesn't happen when using the Vulkan backend

Monitor DP-2 (ID 0):
	[email protected] at 0x0
	description: GIGA-BYTE TECHNOLOGY CO. LTD. M27Q 20120B000001
	make: GIGA-BYTE TECHNOLOGY CO., LTD.
	model: M27Q
	physical size (mm): 600x340
	serial: 20120B000001
	active workspace: 3 (3)
	special workspace: 0 ()
	reserved: 0 34 0 0
	scale: 1.00
	transform: 0
	focused: no
	dpmsStatus: 1
	vrr: true
	solitary: 561649b963f0
	solitaryBlockedBy: null
	activelyTearing: false
	tearingBlockedBy: next frame is not torn,window settings
	directScanoutTo: 561649b963f0
	directScanoutBlockedBy: null
	disabled: false
	currentFormat: XRGB8888
	mirrorOf: none
	availableModes: [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] 
	colorManagementPreset: srgb
	sdrBrightness: 1.00
	sdrSaturation: 1.00
	sdrMinLuminance: 0.20
	sdrMaxLuminance: 80

nothing looks out of the ordinary here

[fxzzi]

just realised it also happens on minecraft native wayland too

[gulafaran]

yeah something about direct_scanout is causing it.

[UjinT34]

Screenshots should block DS. Probably those apps aren't fast enough to switch out of DS and produce a single black frame just before the data gets exported.

[gulafaran]

because this makes it work.

diff --git a/src/render/Renderer.cpp b/src/render/Renderer.cpp
index c4c72c41..26c60f58 100644
--- a/src/render/Renderer.cpp
+++ b/src/render/Renderer.cpp
@@ -1395,7 +1395,7 @@ void CHyprRenderer::renderMonitor(PHLMONITOR pMonitor, bool commit) {
     bool renderCursor = true;

     if (!finalDamage.empty()) {
-        if (pMonitor->m_solitaryClient.expired()) {
+        if (pMonitor->m_solitaryClient.expired() || pMonitor->isDSBlocked() || pMonitor->isSolitaryBlocked()) {
             if (pMonitor->isMirror()) {
                 g_pHyprOpenGL->blend(false);
                 g_pHyprOpenGL->renderMirrored();

[UjinT34]

It's a single fullscreen window which can be used for DS/tearing. Probably it's reset later than it should.

[gulafaran]

trying to see if its reset at all, because there is only a single full screen window so that if (pMonitor->m_solitaryClient.expired()) doesnt hit meaning it doesnt hit the rendermonitor/endrender that is actually doing the screencopy protocol calls. which i assume is the one responsible for screenshots aswell

[fxzzi]

it also happens on cs2 native wayland btw, i never noticed because i usually play stretched res and that doesnt activate ds due to surface transformations

[fxzzi]

also another thing, not sure if related, but I'm unable to toggle CTM stuff like hyprsunset whilst a display is active in DS. When I toggle hyprsunset it works on my secondary display tho. I can make the game windowed, toggle CTM, then fullscreen again without issue