Automatically pin child windows

[ArchSav]

Describe your PR, what does it fix/add?

Implements #11674
When a child window is opened, pin it if the parent is already pinned.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Nothing of note.

Is it ready for merging, or does it need work?

Yes it is ready.

[vaxerski]

tests needed

[ArchSav]

tests needed

Could you elaborate on this a bit,
I am not sure how I would go about making tests for this in hyprtester

[vaxerski]

make a client that listens on stdin and opens a child window when you send something to it, pin it beforehand, check if pinned. See the pointer test client, it does a similar thing for snapping

[ArchSav]

This should be ready to merge now

[ArchSav]

I've implemented those changes
I appreciate the help getting this through :D

[vaxerski]

no worries, it's my job :)

[vaxerski]

I think thats it, rest lgtm

[vaxerski]

c-f needed

[vaxerski]

Your test seems to fail

�[32mPassed: �[0mgetFromSocket("/keyword windowrule float, pin, class:child-test-parent"). Got ok
�[31mFailed: �[0mfn(), expected true, got false. Source: hyprtester/src/main.cpp@240.

Rebase on main and fix the windowrule syntax :P

[vaxerski]

also why the rule even? Just pin the first window via dispatch pin?

[ArchSav]

I have fixed build problems should be ready to merge

Sorry for the hassle of this

[ArchSav]

I have fixed the clang format violation

The failed test doesn't show on the local repo and doesn't relate to anything touched by this pr

[ArchSav]

Merge conflicts fixed

[ArchSav]

Tests failed at the same place as the 'fix includes' commit. There isn't anything I can do for this

[vaxerski]

yes thats good that just happens

[vaxerski]

thanks!

[Aqa-Ib]

crash when opening firefox:
hyprlandCrashReport703.txt

[ryand56]

crash when opening firefox: hyprlandCrashReport703.txt

Can reproduce this.

[ItsOhen]

diff --git a/src/protocols/XDGShell.cpp b/src/protocols/XDGShell.cpp
index ebb56342..12698827 100644
--- a/src/protocols/XDGShell.cpp
+++ b/src/protocols/XDGShell.cpp
@@ -257,11 +257,12 @@ CXDGToplevelResource::CXDGToplevelResource(SP<CXdgToplevel> resource_, SP<CXDGSu
 
         m_parent = newp;
 
-        if (m_parent)
+        if (m_parent) {
             m_parent->m_children.emplace_back(m_self);
 
-        if (m_parent->m_window->m_pinned)
-            m_self->m_window->m_pinned = true;
+            if (m_parent->m_window->m_pinned)
+                m_self->m_window->m_pinned = true;
+        }
 
         LOGM(Log::DEBUG, "Toplevel {:x} sets parent to {:x}{}", (uintptr_t)this, (uintptr_t)newp.get(), (oldParent ? std::format(" (was {:x})", (uintptr_t)oldParent.get()) : ""));
     });

[tannerellen]

Confirmed patch fixes both firefox and thunderbird crash on launch.

[LionHeartP]

I was crashing when launching Lutris, but the above patch fixed it for me as well.