-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CM updates #12693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CM updates #12693
Conversation
|
border shader should be treated as srgb, no? Why would th ecolors shift? |
|
Should there be a difference between |
|
It uses sRGB TF on main and gamma22 with this PR. It's not clear which TF should be used. Looks like a lot of real-world stuff assumes sRGB colorspace with gamma22 TF or even mislabels gamma22 TF as an sRGB TF. |
Is it expected to fail? |
|
no, force push to rerun |
Describe your PR, what does it fix/add?
render:cm_sdr_eotf = 3to use sRGB TF.WP_COLOR_MANAGER_V1_FEATURE_SET_MASTERING_DISPLAY_PRIMARIESandWP_COLOR_MANAGER_V1_FEATURE_EXTENDED_TARGET_VOLUME. This support isn't fully correct, mastering primaries should be used to determine color range for tonemapping and dealing with values outside 0.0 - 1.0 range. Should make gamescope and some other clients happier.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Will make some colors look different by default. Border shader might need a revert or a TF parameter.
Is it ready for merging, or does it need work?
Ready