-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
bind: new long press option #8302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also needs a clang-format
|
this is soo weird huh? yesterday i tested it it works. now i re-clone my repo and checkout that commit and it doesnt work anymore... seem like a issue with longPress var not being registered... |
|
fixed and rebased, check now. |
|
lgtm, ready for merge |
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a wiki mr
|
wait no, bindo should make the other bind = not work unless its released before the timer. i.e. if i have a bind = playerctl position +5 and a bindo = playerctl next solution i can think of rn: bind need to check if theres a bindo for the keybind and if so, only execute the action if on release the timer is not trigger yet, effectively making it bindr(i.e. make bind act like bindr if theres a bindo for it)' but you can't just people to just use replace bind for bindr in these situations as if i have triggered the long press, the bindr shouldn't trigger. |
|
sorry, i don't know how should i make it still call the dispatcher after the |
|
hm... at this point, you're better off just scripting it I believe. It's completely possible with transparent binds, no? bindt = SUPER, O, exec, ~/myScript.sh DOWN
bindrt = SUPER, O, exec, ~/myScript.sh UP
Then your script on UP calculates the Δt and does a |
|
alright then or perhaps bindor will be a good idea lol(another bindo will be needed so if k.longPress and k.release then execute the dispatcher on release if the timer is not up) or maybe this is it? |
|
idk tbh but I have a feeling this is unnecessary clutter for an already cluttered and messy system |
|
alright then. lets just finish it here, pls review the wiki pr and this(fixed a merge conflict) |
|
by that I kinda meant this entire PR. |
|
...idk, but I do feel like this is a quite basic functionality for binds |
|
idk, can you name a single other wayland environment that has this...? |
|
No.. but hyprland advertised
Also, I'm pretty sure some people might want this |
|
fair |
|
Just FYI, I've stumbled upon this PR when configuring long presses in Hyprland. I don't know if there is any well know solution for long press inhibiting the short one but I didn't find any.
I had a go at this idea: https://github.com/Havner/hyprlong/blob/orig/src/main.rs The simpler idea actually utilizing this PR is this: https://github.com/Havner/hyprlong Again, just FYI if someone stumbles upon this. Maybe there is something simpler I haven't found. |
Describe your PR, what does it fix/add?
closes #8245, described there too
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
ready