removed some extra logs

Author: SafiullahOmar

src/dt4acc/core/views/shared_view.py

@@ -24,6 +24,8 @@ def get_view_instance():
         from ...custom_tango.views.result_view import ResultView
         # For Tango, prefix must be in format: server_name/instance_name
         # Check for TANGO_SERVER_NAME and TANGO_INSTANCE_NAME env vars first
+        # waheed ! only one changes need be adjusted wiht epics and env variables 
+        # i have set the server name and instance name in the tango_server.py file please check it if not feasible you can change it and let me know
         server_name = os.environ.get("TANGO_SERVER_NAME", "SimpleTangoServer")
         instance_name = os.environ.get("TANGO_INSTANCE_NAME", "test")
         prefix = f"{server_name}/{instance_name}"

src/dt4acc/custom_tango/views/calculation_result_view.py

@@ -40,7 +40,7 @@ async def update_twiss_pv(pv_name, twiss_result):
 
     # logger.warning(f"Updating twiss values {tune_x, tune_y}")
     try:
-        # todo: use translation service to provide the calc
+        # todo: use translation service to provide the calc may be i will ask waheed on this 
         from .create_or_update_pv import update_twiss_pv as _update_twiss_pv
         await _update_twiss_pv(pv_name, twiss_result)
         logger.debug("Updated twiss values")
@@ -55,7 +55,7 @@ def __init__(self, *, prefix):
 
     async def push_value(self, elm_update: ElementUpdate):
         if elm_update.property_name == "K":
-            # to create a future
+            
             await asyncio.sleep(0.0)
         else:
             property_name = 'x:set' if 'x' in elm_update.property_name else (
@@ -68,10 +68,10 @@ async def push_orbit(self, orbit_result: Orbit):
         logger.warning(
             f"{self.__class__.__name__} Orbit pushing view orbit result is none ? {orbit_result is None}")
 
-        # Define the device name for Tango (prefix is already server_name/instance_name)
+        # Define the device name for Tango (prefix is already server_name/instance_name) becuase already defined in the prefix and during the initialization of the view
         device_name = f"{self.prefix}/twiss_orbit_device"
 
-        # Use the new function to update the structured Orbit PV
+        
         try:
             await update_orbit_pv(device_name, orbit_result)
         except Exception as exc:
@@ -81,13 +81,11 @@ async def push_orbit(self, orbit_result: Orbit):
             logger.info('Orbit pushed view')
 
     async def push_twiss(self, twiss_result: TwissWithAggregatedKValues):
-        # logger.warning('Twiss pushing view')
-
-        # Define the device name for Tango (prefix is already server_name/instance_name)
+        
         device_name = f"{self.prefix}/twiss_orbit_device"
 
         if twiss_result is None:
             return
-        # Use the bulk update function to update the structured PV
+        
         await update_twiss_pv(device_name, twiss_result)
         logger.info('Twiss pushed view')

src/dt4acc/custom_tango/views/repeated_publishing_view.py

@@ -65,7 +65,7 @@ async def push(self, data):
             # Note: count attribute is READ_ONLY, so we only write bdata
             bdata_attr_name = f"{special_pvs['bpm_pv']}/bdata"
 
-            # Clean data and ensure proper format
+            
             if isinstance(data, np.ndarray):
                 # Clean NaN/INF values and convert to int16
                 data_clean = np.nan_to_num(data, nan=-2**15+1, posinf=-2**15+1, neginf=-2**15+1)
@@ -94,7 +94,6 @@ async def push(self, data):
             return
 
         try:
-            prefix = f"{self.prefix}:ORBITCC"
             # Todo: check that the dimensions are properly made
             # Extract x and y positions
             x_positions = data.loc[:, "x"].fillna(0.0).values  # Replace NaN with 0.0
@@ -142,13 +141,7 @@ async def push(self, data: TuneData):
         tune_x = float(data.x)
         tune_y = float(data.y)
 
-        # currently adding very small noise to get data republished
-        # need to check softioc what its records can do
-        tune_x += np.random.uniform(-1e-12, 1e-12)
-        tune_y += np.random.uniform(-1e-12, 1e-12)
-
         try:
-            prefix = f"{self.prefix}:TUNECC"
             device_name = f"{self.prefix}/tune_device"
             device = DeviceProxy(device_name)
 
@@ -160,11 +153,7 @@ async def push(self, data: TuneData):
                 None,
                 lambda: device.write_attribute("y", tune_y)
             )
-            #await asyncio.get_event_loop().run_in_executor(
-            #    None,
-            #    lambda: device.write_attribute(f"{prefix}:count", int(next(self.counter)))
-            #)
-            # Todo: check that the dimensions are properly made
+        
         except Exception as e:
             logger.error(f"Error processing tune object data: {e}")
 
@@ -180,7 +169,7 @@ def __init__(self, *, prefix):
         self.legacy_bpm_publisher.set_data(tmp)
         self.orbit_object_publisher = PeriodicPublisher(view=OrbitView(prefix=prefix), name="orbit")
         self.tune_publisher = PeriodicPublisher(view=TuneView(prefix=prefix), name="tune")
-        # todo: fix this design flaw
+        
         self.bpm_mimicry = None
         self.bpm_filter = ExtractBPMFromOrbitFilter()