fixing warning and updating to version 1.0.1

Author: hzitoun

.idea/modules.xml

@@ -7,8 +7,8 @@ android {
         applicationId "com.hzitoun.camera2secretpicturetaker"
         minSdkVersion 21
         targetSdkVersion 25
-        versionCode 1
-        versionName "1.0"
+        versionCode 2
+        versionName "1.0.1"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
         jackOptions {
             enabled true

app/build.gradle

@@ -26,7 +26,7 @@
 
 
 /**
- * App's Main Activity
+ * App's Main Activity showing a simple usage of the picture taking service.
  *
  * @author hzitoun ([email protected])
  */
@@ -107,6 +107,9 @@ public void onRequestPermissionsResult(int requestCode,
         }
     }
 
+    /**
+     * checking  permissions at Runtime.
+     */
     @TargetApi(Build.VERSION_CODES.M)
     private void checkPermissions() {
         final String[] requiredPermissions = {

app/src/main/java/com/hzitoun/camera2SecretPictureTaker/activities/MainActivity.java

@@ -9,13 +9,13 @@
 import com.hzitoun.camera2SecretPictureTaker.listeners.PictureCapturingListener;
 
 /**
- * Abstract Picture taking service.
+ * Abstract Picture Taking Service.
  *
  * @author hzitoun ([email protected])
  */
 public abstract class APictureCapturingService {
 
-    public static final SparseIntArray ORIENTATIONS = new SparseIntArray();
+    private static final SparseIntArray ORIENTATIONS = new SparseIntArray();
 
     static {
         ORIENTATIONS.append(Surface.ROTATION_0, 90);
@@ -25,8 +25,8 @@ public abstract class APictureCapturingService {
     }
 
     private final Activity activity;
-    protected final Context context;
-    protected final CameraManager manager;
+    final Context context;
+    final CameraManager manager;
 
     /***
      * constructor.
@@ -40,9 +40,9 @@ public abstract class APictureCapturingService {
     }
 
     /***
-     * get display orientation
-     * */
-    protected int getOrientation() {
+     * @return  orientation
+     */
+    int getOrientation() {
         final int rotation = this.activity.getWindowManager().getDefaultDisplay().getRotation();
         return ORIENTATIONS.get(rotation);
     }

app/src/main/java/com/hzitoun/camera2SecretPictureTaker/services/APictureCapturingService.java

@@ -41,34 +41,38 @@
 
 /**
  * The aim of this service is to secretly take pictures (without preview or opening device's camera app)
- * from all available cameras.
+ * from all available cameras using Android Camera 2 API
  *
  * @author hzitoun ([email protected])
  */
 
-@TargetApi(Build.VERSION_CODES.LOLLIPOP) //camera 2 api was added in API level 21
+@TargetApi(Build.VERSION_CODES.LOLLIPOP) //NOTE: camera 2 api was added in API level 21
 public class PictureCapturingServiceImpl extends APictureCapturingService {
 
     private static final String TAG = PictureCapturingServiceImpl.class.getSimpleName();
 
-    private boolean cameraClosed;
     private CameraDevice cameraDevice;
     private ImageReader imageReader;
+    /***
+     * camera ids queue.
+     */
+    private Queue<String> cameraIds;
+    private String currentCameraId;
+    private boolean cameraClosed;
+    /**
+     * stores a sorted map of (pictureUrlOnDisk, PictureData).
+     */
     private TreeMap<String, byte[]> picturesTaken;
     private PictureCapturingListener capturingListener;
-    private String currentCameraId;
-    //camera ids queue;
-    private Queue<String> cameraIds;
-
 
     /***
-     * private constructor, meant to force the use of {@see getInstance} method
+     * private constructor, meant to force the use of {@link #getInstance}  method
      */
     private PictureCapturingServiceImpl(final Activity activity) {
         super(activity);
     }
-    
-     /**
+
+    /**
      * @param activity the activity used to get the app's context and the display manager
      * @return a new instance
      */
@@ -92,9 +96,10 @@ public void startCapturing(final PictureCapturingListener listener) {
                 this.currentCameraId = this.cameraIds.poll();
                 openCamera();
             } else {
+                //No camera detected!
                 capturingListener.onDoneCapturingAllPhotos(picturesTaken);
             }
-        } catch (CameraAccessException e) {
+        } catch (final CameraAccessException e) {
             Log.e(TAG, "Exception occurred while accessing the list of cameras", e);
         }
     }
@@ -109,7 +114,7 @@ private void openCamera() {
                     == PackageManager.PERMISSION_GRANTED) {
                 manager.openCamera(currentCameraId, stateCallback, null);
             }
-        } catch (CameraAccessException e) {
+        } catch (final CameraAccessException e) {
             Log.e(TAG, " exception occurred while opening camera " + currentCameraId, e);
         }
     }
@@ -146,13 +151,12 @@ public void onOpened(@NonNull CameraDevice camera) {
             Log.i(TAG, "Taking picture from camera " + camera.getId());
             //Take the picture after some delay. It may resolve getting a black dark photos.
             new Handler().postDelayed(() -> {
-                        try {
-                            takePicture();
-                        } catch (CameraAccessException e) {
-                            Log.e(TAG, " exception occurred while taking picture from " + currentCameraId, e);
-                        }
-                    }
-                    , 500);
+                try {
+                    takePicture();
+                } catch (final CameraAccessException e) {
+                    Log.e(TAG, " exception occurred while taking picture from " + currentCameraId, e);
+                }
+            }, 500);
         }
 
         @Override
@@ -255,5 +259,4 @@ private void closeCamera() {
     }
 
 
- 
 }