A couple of php deprecations

[adixon]

As reported by the webform_civicrm D10 test matrix.

Deprecated function: Return type of Faps_Transaction::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed (line 30 of sites/simpletest/64253304/files/civicrm/ext/com.iatspayments.civicrm/CRM/Iats/FapsRequest.php)

Deprecated function: current(): Calling current() on an object is deprecated in CRM_Iats_iATSServiceRequest->result() (line 275 of sites/simpletest/55092078/files/civicrm/ext/com.iatspayments.civicrm/CRM/Iats/iATSServiceRequest.php)

[demeritcowboy]

Just a note that the first one is tricky because in php 7 it interprets "mixed" as a class type called "mixed", so is expecting the return value to be an instance of class "mixed".

There is the #[ReturnTypeWillChange] annotation but it feels wrong and later you'll have to go thru and update them all anyway to mixed and remove that annotation. One solution is to only support either php 7 or php 8 in a given release, but that's difficult in civiland. So the annotation is simplest.

[adixon]

Thanks for this! Saved me from going down that rabbit hole!

[adixon]

The first of the deprecated functions is still generating deprecation warnings ...