Address code review feedback on profile selection

- Drop dead connectedByInstance map in renderProfilesList; only directory
  lookup is consulted and the "unresolved host" footer already covers
  connected hosts whose instanceId did not resolve.
- Drop the misleading `--timeout` flag on `obu profiles --connected`;
  the probe was always hard-capped at 800ms regardless of the flag.
- Cap LevelDB scan reads at 32 MB so a pathological file can't OOM the
  host. chrome.storage.local logs are well under 1 MB in practice.
- Clean up unused `picked` return from pickSocketForProfile in
  dialBrowserSocketForProfile.
- Skill: split single-profile guidance into "installed and connected"
  vs "installed but Chrome closed" so agents prompt the user to open
  Chrome instead of silently retrying a doomed connection.
- Plan TC-2: update the JSON field list to match the actual `obu
  profiles --json` and `--connected --json` outputs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: 2 people

cmd/open-browser-use/main.go

@@ -35,6 +35,10 @@ const chromeWebStoreUpdateURL = "https://clients2.google.com/service/update2/crx
 const chromeWebStoreExtensionURL = "https://chromewebstore.google.com/detail/open-browser-use/" + defaultChromeExtensionID + "?utm_source=open-computer-use"
 const betaExtensionPublicKey = "MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAnBLT95WWVnHYH0pOBRH/eP+BWtlKVmLE/RHkERUTI2+PGDSQrbWVabmTw4CZ3yhjko04dijSX2Az8cnp65xh23Dh5mP5TCtiP9LexRFJokd8EsyeFdtKamMYr0hF1ZUc1/8ZpLnetAU65ZMB9VzHQBqpJWeUwuIvecgfRtGklDgJMjnvcq5J6pttZrzWrI/2B0BNufwsTQfEt7qLtDFPHXmUdtZfQbc2EfYFvkXLDAXicYviiocedrsAGIKUxpyQegobhUFL+tNLOuXKBpZlLFQn3xgm5CyGZwN6bueiV/S7reigVTKAMQ8BX0eacT22e8r0UzjsjkugeHOIonIvtQIDAQAB"
 
+// LevelDB log/ldb files for chrome.storage.local are typically under 1 MB; cap
+// the scan at 32 MB so a pathological file can't OOM the host.
+const maxLevelDBScanBytes = 32 << 20
+
 func main() {
 	if err := run(os.Args[1:]); err != nil {
 		fmt.Fprintln(os.Stderr, err)
@@ -747,6 +751,10 @@ func resolveProfileForInstanceID(extensionID string, instanceID string) (directo
 			if !strings.HasSuffix(name, ".log") && !strings.HasSuffix(name, ".ldb") {
 				continue
 			}
+			info, err := entry.Info()
+			if err != nil || info.Size() > maxLevelDBScanBytes {
+				continue
+			}
 			payload, err := os.ReadFile(filepath.Join(storageDir, name))
 			if err != nil {
 				continue
@@ -1350,7 +1358,6 @@ func newProfilesCommand() *cobra.Command {
 	var asJSON bool
 	var connected bool
 	var socketDir string
-	var timeout time.Duration
 	cmd := &cobra.Command{
 		Use:   "profiles",
 		Short: "List Chrome profiles that have the Open Browser Use extension installed",
@@ -1362,29 +1369,25 @@ func newProfilesCommand() *cobra.Command {
 			}
 			var connections []connectedProfileInfo
 			if connected {
-				connections = probeConnectedProfiles(socketDir, timeout)
+				connections = probeConnectedProfiles(socketDir)
 			}
 			return renderProfilesList(cmd.OutOrStdout(), profiles, connections, connected, asJSON)
 		},
 	}
 	cmd.Flags().BoolVar(&asJSON, "json", false, "emit JSON instead of a human-readable table")
 	cmd.Flags().BoolVar(&connected, "connected", false, "also probe running hosts and mark which profile is currently connected")
 	cmd.Flags().StringVar(&socketDir, "socket-dir", host.DefaultSocketDir, "directory containing host sockets (used with --connected)")
-	cmd.Flags().DurationVar(&timeout, "timeout", 2*time.Second, "per-socket probe timeout (used with --connected)")
 	return cmd
 }
 
-func probeConnectedProfiles(socketDir string, timeout time.Duration) []connectedProfileInfo {
+const connectedProbeTimeout = 800 * time.Millisecond
+
+func probeConnectedProfiles(socketDir string) []connectedProfileInfo {
 	candidates, err := listSocketCandidates(socketDir)
 	if err != nil || len(candidates) == 0 {
 		return nil
 	}
-	probeTimeout := timeout
-	if probeTimeout <= 0 {
-		probeTimeout = 800 * time.Millisecond
-	} else if probeTimeout > 800*time.Millisecond {
-		probeTimeout = 800 * time.Millisecond
-	}
+	probeTimeout := connectedProbeTimeout
 	var out []connectedProfileInfo
 	for _, candidate := range candidates {
 		conn, err := net.DialTimeout("unix", candidate.path, probeTimeout)
@@ -1403,14 +1406,10 @@ func probeConnectedProfiles(socketDir string, timeout time.Duration) []connected
 
 func renderProfilesList(writer io.Writer, profiles []installedChromeProfile, connected []connectedProfileInfo, showConnected bool, asJSON bool) error {
 	connectedByDir := map[string]connectedProfileInfo{}
-	connectedByInstance := map[string]connectedProfileInfo{}
 	for _, info := range connected {
 		if info.Directory != "" {
 			connectedByDir[info.Directory] = info
 		}
-		if info.InstanceID != "" {
-			connectedByInstance[info.InstanceID] = info
-		}
 	}
 
 	if asJSON {
@@ -2127,11 +2126,10 @@ func dialBrowserSocketForProfile(socketPath string, socketDir string, profile st
 		}
 		return conn, nil
 	}
-	conn, picked, _, err := pickSocketForProfile(socketDir, profile, timeout)
+	conn, _, _, err := pickSocketForProfile(socketDir, profile, timeout)
 	if err != nil {
 		return nil, err
 	}
-	_ = picked
 	return conn, nil
 }
 

docs/exec-plans/active/2026-05-12-chrome-profile-selection.md

@@ -107,7 +107,8 @@
 
 2. **TC-2 多 profile：列表正确**
    - 同时启动 `Default` 和 `Profile 1` 两个 Chrome 窗口。
-   - 运行 `obu profiles --json` → 期望返回 2 条：每条包含 `directory`、`displayName`、`extensionVersion`、`socket`、`active`（其中之一为 `true`）。
+   - 运行 `obu profiles --json` → 期望返回 2 条：每条包含 `directory`、`displayName`、`extensionId`、`version`、`source`。
+   - 运行 `obu profiles --connected --json` → 同上，额外多出 `connected: true`、`socketPath`、`instanceId`。
    - 展示名应该和 Chrome 头像菜单里看到的一致。
 
 3. **TC-3 显式指定 profile**

skills/open-browser-use/SKILL.md

@@ -52,23 +52,29 @@ picking whatever Chrome window happens to be active.
    (whether that profile's host is currently reachable). JSON output is
    available via `--json`.
 
-2. If exactly one profile is installed, proceed without asking.
+2. If exactly one profile is installed and its `CONNECTED` column is `yes`,
+   proceed without asking.
 
-3. If more than one profile is installed, ask the user which to use unless the
-   user already specified one in the original task ("use my work profile",
-   "do this on cookiy.com"). When asking, list both directory name and display
-   name so the user can recognize them.
+3. If a profile is installed but `CONNECTED` is `-`, the user's Chrome is not
+   open on that profile. Ask the user to open Chrome on that profile (naming it
+   by display name so it is unambiguous) before retrying — do not run browser
+   commands yet, the connection will just fail.
 
-4. After the user has chosen, pass `--profile <selector>` to every CLI / MCP
+4. If more than one profile is installed and connected, ask the user which to
+   use unless the user already specified one in the original task ("use my work
+   profile", "do this on cookiy.com"). When asking, list both directory name
+   and display name so the user can recognize them.
+
+5. After the user has chosen, pass `--profile <selector>` to every CLI / MCP
    command for the rest of the task. The selector accepts either the directory
    name (`Default`, `Profile 1`) or the display name (`Eva`, `cookiy.com`),
    case-insensitive. Do not switch profiles mid-task.
 
-5. If `--profile` does not match any running host, the CLI prints which
+6. If `--profile` does not match any running host, the CLI prints which
    profiles are currently connected. Ask the user to open Chrome on the chosen
    profile, then retry; do not silently fall back to a different profile.
 
-6. For MCP, lock the profile at server start:
+7. For MCP, lock the profile at server start:
 
    ```toml
    [mcp_servers.open_browser_use]
@@ -79,7 +85,7 @@ picking whatever Chrome window happens to be active.
    Do not pass profile as a per-tool-call argument — the MCP server applies the
    start-time selector to every call.
 
-7. Do not remember the user's profile choice across unrelated tasks. A future
+8. Do not remember the user's profile choice across unrelated tasks. A future
    task may belong to a different profile; ask again rather than assuming.
 
 ## Common CLI Actions