Merge pull request #18 from anhofmann/patch-3

amenk · web-flow · commit 5b75ebd803fc · 2024-03-21T10:27:57.000+01:00
Don't add "?" to URL if $queryParameters is empty
diff --git a/src/UrlGeneratorService.php b/src/UrlGeneratorService.php
@@ -26,7 +26,9 @@ private function addSid(string $url, ?\Illuminate\Routing\Route $route = null):
 
         // Rebuild the URL
         $url = str_replace('?' . $queryString, '', $url);
-        $url .= '?' . http_build_query($queryParameters);
+        if(!empty($queryParameters)) {
+            $url .= '?' . http_build_query($queryParameters);
+        }
 
         return $url;
     }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,9 @@ private function addSid(string $url, ?\Illuminate\Routing\Route $route = null):`
`26`	`26`
`27`	`27`	`// Rebuild the URL`
`28`	`28`	`$url = str_replace('?' . $queryString, '', $url);`
`29`		`- $url .= '?' . http_build_query($queryParameters);`
	`29`	`+ if(!empty($queryParameters)) {`
	`30`	`+ $url .= '?' . http_build_query($queryParameters);`
	`31`	`+ }`
`30`	`32`
`31`	`33`	`return $url;`
`32`	`34`	`}`