Skip to content

Commit a0192db

Browse files
committed
Address copilot comments
1 parent 757ee00 commit a0192db

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

common/changes/@itwin/core-backend/sheetalNair-fix-text-outline_2026-03-20-10-17.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"changes": [
33
{
44
"packageName": "@itwin/core-backend",
5-
"comment": "Add outline geometry as Path instead of Loop in TextAnnotation2d",
5+
"comment": "Add outline geometry as Path instead of Loop in text annotations",
66
"type": "none"
77
}
88
],

core/backend/src/test/annotations/FrameGeometry.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import { expect } from "chai";
7-
import { CurvePrimitive, Geometry, Point3d, Range2d, Transform, Vector3d } from "@itwin/core-geometry";
7+
import { CurvePrimitive, Geometry, Path, Point3d, Range2d, Transform, Vector3d } from "@itwin/core-geometry";
88
import { ColorDef, GeometryParams, textAnnotationFrameShapes, TextFrameStyleProps } from "@itwin/core-common";
99
import { appendFrameToBuilder, computeFrame } from "../../annotations/FrameGeometry";
1010
import { Id64 } from "@itwin/core-bentley";
@@ -46,6 +46,7 @@ describe("FrameGeometry", () => {
4646
const result = appendFrameToBuilder(builder, frame, defaultRange, defaultTransform, defaultParams);
4747
expect(result).to.be.true;
4848
expect(builder.geometries.length).to.be.equal(2);
49+
expect(builder.geometries[1] instanceof Path).to.be.true; // The second geometry should be the outline geometry, which is a Path
4950
});
5051

5152
it("should set fill and border colors from frame", () => {

0 commit comments

Comments
 (0)