How to get the property Field of PropertyRecord in property-grid-react

[XinJack]

In the onPropertyUpdated callback of property-grid-react, I am trying to use the IPresentationPropertyDataProvider.getFieldByPropertyDescription(PropertyRecord.property) API to retrieve the corresponding field for a property. This works correctly for simple properties but fails for properties nested within a struct or a struct array.

For example, given an element with an EC struct as shown below, the API successfully returns the field for the "stringProp" with the value "345", but fails for the "stringProp" with the value "123".

{
    // ... other properties
    structProp: 
    {
        stringProp: "123"
    },
    stringProp: "345"
}

I observed that for the top-level "stringProp" (value "345"), its property name is "pc_schemaAlias_className_stringProp", while for the nested "structProp:stringProp", its property name is only "stringProp". This difference is likely why the API does not work for the nested property.

I wonder if this is a bug for the API and whether is there a more reliable way to locate the exact property path within an element for a given PropertyRecord.

[grigasp]

Hi @XinJack, thanks for reporting this. I created an issue for it: iTwin/presentation#1156.

[XinJack]

Hi @XinJack, thanks for reporting this. I created an issue for it: iTwin/presentation#1156.

Thanks for your follow-up.

On a related note, I also noticed a potential bug in the property-grid-react component. It currently allows users to edit the CodeValue and UserLabel fields, but basicManipulationIpc.updateGeometricElement fails to update them—likely because these fields are not editable on the backend. Therefore, I think it would be better if the property-grid-react component could disable editing for these fields to prevent user confusion.

[grigasp]

I'm pretty sure CodeValue and UserLabel are editable, but I'm no expert in editing area. @aruniverse, any idea who could help on that?

[aruniverse]

UserLabel makes sense to be editable. However, idk if CodeValue should be edited directly by a user.

• @ColinKerr thoughts?

[XinJack]

Within the BisCore.ecschema.xml, both the CodeValue and UserLabel ECProperty carry the CustomHandledProperty ECCustomAttribute. CustomHandledProperty's description states: "Applied to an element's property to indicate that the property's value is handled specially by a C++ class." Could this be why basicManipulationIpc.updateGeometricElement fails to update them?