Skip to content

Entity request failures not logged as errors #1

@iaincollins

Description

@iaincollins

if the cache is reset then it will force the script to update all metadata for all guests from the Wikipedia API.

This will trigger > 1000 API requests. Although it will make the requests synchronously, to reduce the impact of hitting rate limits, some of which may still fail and the guests will subsequently be recorded as party "Unknown" as it will have no metadata for them.

For now this currently mitigated by running the script twice if the cache is ever rebuilt from scratch and checking the cache size to ensure it's at least as large as it was before.

This issue can be resolved by changing the command line interface to save the data directly to an output file rather than having to be concatenated into a file, allowing errors to be logged to the console (without impacting the data output to CSV).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions