fix: resolve ci lint and smart search tests

Author: claude

server/src/mcp-server.ts

@@ -31,14 +31,12 @@ async function bootstrap() {
     name: 'secbot-mcp',
     version: '1.0.0',
   });
-  const registerTool = (server as any).registerTool.bind(server) as any;
-
   for (const tool of toolsService.getAllTools()) {
     if (tool.sensitive && !allowSensitive) {
       continue;
     }
 
-    registerTool(
+    server.registerTool(
       tool.name,
       {
         title: tool.name,

server/src/modules/agents/core/explore-agent.ts

@@ -66,7 +66,7 @@ export interface ExploreArgs {
   intent?: IntentDecision;
   contextBlock?: string;
   onEvent?: OnEventCallback;
-  /** 默认 3 */
+  /** 默认 12，可用 SECBOT_EXPLORE_MAX_ITERS 覆盖 */
   maxIterations?: number;
 }
 
@@ -101,7 +101,7 @@ export class ExploreAgent extends BaseAgent {
   async explore(args: ExploreArgs): Promise<ContextPatch> {
     const { userInput, intent, contextBlock, onEvent } = args;
     const defaultMax = resolveDefaultMaxIterations();
-    const maxIterations = args.maxIterations ?? Infinity;
+    const maxIterations = args.maxIterations ?? defaultMax;
 
     /** 为本次 explore 生成独立的虚拟浏览器 session_id，结束时主动关闭 */
     const browserSessionId = `expl-${Date.now().toString(36)}-${Math.random()

server/src/modules/agents/core/intent-router.ts

@@ -141,7 +141,7 @@ export class IntentRouter {
     } catch {
       /* LLM 不可用 / 解析失败：走启发式 */
     }
-    return this.fallback(args.userInput, heuristic, args);
+    return this.fallback(heuristic);
   }
 
   private parse(raw: string): IntentDecision | null {
@@ -191,11 +191,7 @@ export class IntentRouter {
     };
   }
 
-  private fallback(
-    userInput: string,
-    heuristic: ReturnType<IntentRouter['heuristic']>,
-    args: IntentRouteArgs,
-  ): IntentDecision {
+  private fallback(heuristic: ReturnType<IntentRouter['heuristic']>): IntentDecision {
     let intent: Intent = 'qa';
     if (heuristic.isSmallTalk) intent = 'small_talk';
     else if (heuristic.isMeta) intent = 'meta';

server/src/modules/chat/chat.service.ts

@@ -61,9 +61,7 @@ export class ChatService {
     body: ChatRequestDto,
     onSSEEvent?: (eventName: string, data: Record<string, unknown>) => void,
   ): Promise<string> {
-    const { message, mode, agent: agentType, client_shell: clientShell, model: modelName } = body;
-    const forceQA = message.trim().startsWith('/ask ');
-    const forceAgent = mode === 'agent' || message.trim().startsWith('/agent ');
+    const { message, agent: agentType, client_shell: clientShell, model: modelName } = body;
     const sessionId = (body.session_id ?? '').trim() || this.defaultSessionId;
     this.getOrCreateSession(sessionId, agentType);
     this.appendSessionMessage(sessionId, MessageRole.USER, message);
@@ -78,14 +76,11 @@ export class ChatService {
     try {
       return await this._handleMessageCore({
         message,
-        mode,
         agentType,
         clientShell,
         modelName,
         sessionId,
         session,
-        forceQA,
-        forceAgent,
         emit,
       });
     } catch (error) {
@@ -98,27 +93,14 @@ export class ChatService {
 
   private async _handleMessageCore(params: {
     message: string;
-    mode?: string;
     agentType?: string;
     clientShell?: ChatRequestDto['client_shell'];
     modelName?: string;
     sessionId: string;
     session: Session;
-    forceQA: boolean;
-    forceAgent: boolean;
     emit: (name: string, data: Record<string, unknown>) => void;
   }): Promise<string> {
-    const {
-      message,
-      agentType,
-      clientShell,
-      modelName,
-      sessionId,
-      session,
-      forceQA,
-      forceAgent,
-      emit,
-    } = params;
+    const { message, agentType, clientShell, modelName, sessionId, session, emit } = params;
 
     /** 1) 启发式 focus 即时更新（IP/CVE/域名/URL/协议词） */
     this.contextAssembler.updateFocusFromInput(sessionId, message);
@@ -193,7 +175,7 @@ export class ChatService {
 
     /** 5) 组装最终上下文（按当前模型预算 + focus 加权 + pinned 优先级） */
     const selectedAgent = this.agents[agentType ?? 'hackbot'] ?? this.agents['hackbot'];
-    const effectiveModelName = modelName || (selectedAgent as any).llm?.model || undefined;
+    const effectiveModelName = modelName || resolveAgentModelName(selectedAgent);
     const context = await this.contextAssembler.build({
       query: message,
       session,
@@ -408,7 +390,7 @@ export class ChatService {
       return {
         handled: true,
         result: (async () => {
-          const qaModelName = modelName || (this.qaAgent as any).llm?.model || undefined;
+          const qaModelName = modelName || resolveAgentModelName(this.qaAgent);
           const ctx = await this.contextAssembler.build({
             query: message,
             session,
@@ -498,3 +480,20 @@ export class ChatService {
     }
   }
 }
+
+function resolveAgentModelName(agent: unknown): string | undefined {
+  if (!agent || typeof agent !== 'object' || !('llm' in agent)) {
+    return undefined;
+  }
+
+  try {
+    const llm = (agent as { llm?: unknown }).llm;
+    if (!llm || typeof llm !== 'object' || !('model' in llm)) {
+      return undefined;
+    }
+    const model = (llm as { model?: unknown }).model;
+    return typeof model === 'string' && model.trim() ? model : undefined;
+  } catch {
+    return undefined;
+  }
+}

server/src/modules/skills/skills.service.ts

@@ -5,7 +5,6 @@ import { CreateSkillRequestDto, SkillDetailDto, SkillSummaryDto } from './dto/sk
 import { SkillFrontmatter, SkillRecord } from './skills.types';
 
 const FRONTMATTER_BOUNDARY = '---';
-const DEFAULT_BODY = '# Overview\n\nDescribe what this skill does and when to use it.\n';
 const DEFAULT_DESCRIPTION = 'Custom Secbot skill.';
 const DEFAULT_AUTHOR = 'Secbot';
 const DEFAULT_VERSION = '1.0.0';

server/src/modules/tools/protocol/ldap-enum.tool.ts

@@ -23,6 +23,7 @@ export class LdapEnumTool extends BaseTool {
         result: {
           host,
           port,
+          base_dn: baseDn || undefined,
           reachable: true,
           banner_bytes: banner.length,
           anonymous_bind: anonBind.success,

server/src/modules/tools/security/sniff.tool.ts

@@ -121,10 +121,14 @@ export class SniffTool extends BaseTool {
             : err.message,
         });
       });
-      child.on('close', () => {
+      child.on('close', (code) => {
         if (done) return;
         done = true;
         clearTimeout(timer);
+        if (code && code !== 0) {
+          resolve({ stdout, error: stderr.trim() || `tshark 退出码 ${code}` });
+          return;
+        }
         resolve({ stdout });
       });
     });

server/src/modules/tools/web-research/smart-search.tool.ts

@@ -132,24 +132,28 @@ export class SmartSearchTool extends BaseTool {
 
   private async searchDDGHtml(query: string, maxResults: number): Promise<SearchResult[]> {
     const url = `https://html.duckduckgo.com/html/?q=${encodeURIComponent(query)}`;
-    try {
-      const html = await this.fetchWithRetry(url, { headers: { 'User-Agent': BROWSER_UA } });
-      if (!html) return [];
-      return this.parseDDGHtml(html, maxResults);
-    } catch {
-      return [];
-    }
+    const html = await this.fetchWithRetry(
+      url,
+      { headers: { 'User-Agent': BROWSER_UA } },
+      0,
+      SEARCH_TIMEOUT_MS,
+    );
+    if (!html) return [];
+    const htmlResults = this.parseDDGHtml(html, maxResults);
+    if (htmlResults.length > 0) return htmlResults;
+    return this.parseDuckDuckGoLite(html, maxResults);
   }
 
   private async searchDDGLite(query: string, maxResults: number): Promise<SearchResult[]> {
     const url = `https://lite.duckduckgo.com/lite/?q=${encodeURIComponent(query)}`;
-    try {
-      const html = await this.fetchWithRetry(url, { headers: { 'User-Agent': BROWSER_UA } });
-      if (!html) return [];
-      return this.parseDuckDuckGoLite(html, maxResults);
-    } catch {
-      return [];
-    }
+    const html = await this.fetchWithRetry(
+      url,
+      { headers: { 'User-Agent': BROWSER_UA } },
+      0,
+      SEARCH_TIMEOUT_MS,
+    );
+    if (!html) return [];
+    return this.parseDuckDuckGoLite(html, maxResults);
   }
 
   private parseDDGHtml(html: string, maxResults: number): SearchResult[] {