Skip to content

Commit e74c098

Browse files
authored
Merge pull request #23 from olleolleolle/patch-1
CI: Add a GitHub Actions matrix
2 parents cc27f27 + 96619ca commit e74c098

File tree

6 files changed

+49
-18
lines changed

6 files changed

+49
-18
lines changed

.github/workflows/ci.yml

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
name: CI
2+
3+
on:
4+
push:
5+
pull_request:
6+
7+
jobs:
8+
ruby-versions:
9+
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
10+
with:
11+
min_version: 3.1
12+
engine: cruby
13+
14+
test:
15+
needs: ruby-versions
16+
name: Ruby ${{ matrix.ruby-version}}, Rails ${{ matrix.rails-version }}
17+
runs-on: ubuntu-latest
18+
env:
19+
RAILS_VERSION: ${{ matrix.rails-version }}
20+
21+
strategy:
22+
matrix:
23+
ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
24+
rails-version:
25+
- "~> 7.0"
26+
- "~> 7.1"
27+
- "~> 7.2"
28+
29+
steps:
30+
- uses: actions/checkout@v4
31+
- name: Set up Ruby ${{ matrix.ruby-version }}
32+
uses: ruby/setup-ruby@v1
33+
with:
34+
ruby-version: ${{ matrix.ruby-version }}
35+
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
36+
- name: Run tests
37+
run: bundle exec rake

.travis.yml

Lines changed: 0 additions & 12 deletions
This file was deleted.

README.rdoc

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ Handle PayPal Express Checkout.
44
Both Instance Payment and Recurring Payment are supported.
55
Express Checkout for Digital Goods is also supported.
66

7-
{<img src="https://travis-ci.org/ianfleeton/paypal-express.svg" />}[https://travis-ci.org/ianfleeton/paypal-express]
8-
97
== Deprecation warning
108

119
Many, or perhaps all, of the APIs used in this gem have been {deprecated}[https://developer.paypal.com/docs/archive/express-checkout/] since January 2017.
@@ -33,6 +31,14 @@ Play with Sample Rails App
3331
https://github.com/ianfleeton/paypal-express-sample
3432
https://paypal-express-sample.heroku.com
3533

34+
== Compatibility
35+
36+
We run tests on these versions of activesupport:
37+
38+
- 7.0
39+
- 7.1
40+
- 7.2
41+
3642
== Note on Patches/Pull Requests
3743

3844
* Fork the project.

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.8.7
1+
1.0.0

ianfleeton-paypal-express.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
1414
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
1515
s.files = `git ls-files`.split("\n")
1616
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
17-
s.add_dependency 'activesupport', '>= 4.2', '< 8'
17+
s.add_dependency 'activesupport', '>= 7.0', '< 8'
1818
s.add_dependency 'rest-client', '~> 2.0'
1919
s.add_dependency 'attr_required', '~> 1.0'
2020
s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.0'

lib/paypal/payment/recurring.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def to_params
2020
params.merge! attribute.to_params
2121
end
2222
if self.start_date.is_a?(Time)
23-
self.start_date = self.start_date.to_s(:db)
23+
self.start_date = self.start_date.to_fs(:db)
2424
end
2525
params.merge!(
2626
:DESC => self.description,
@@ -40,4 +40,4 @@ def numeric_attribute?(key)
4040
end
4141
end
4242
end
43-
end
43+
end

0 commit comments

Comments
 (0)