fix: await updateComplete before hiding icon so unlocked_icon renders first - #192
Closed
iantrich wants to merge 1 commit into
Closed
fix: await updateComplete before hiding icon so unlocked_icon renders first#192iantrich wants to merge 1 commit into
iantrich wants to merge 1 commit into
Conversation
… first When _unlocked is set to true, Lit schedules an async re-render to show the unlocked_icon. Previously, icon-hidden was added synchronously before that re-render could complete, so the unlocked_icon was always hidden before it ever appeared. Awaiting updateComplete ensures the re-render runs first, making the unlocked_icon briefly visible before fading out. Fixes #183 Co-authored-by: Ian Richardson <iantrich@users.noreply.github.com>
2 tasks
Owner
Author
|
This fix Claude came up with looks to be against the master branch. Bad Claude :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183
When
_unlockedis set totrue, Lit schedules an async re-render to show theunlocked_icon. Previously,icon-hiddenwas added synchronously before that re-render could complete, so theunlocked_iconwas always hidden before it ever appeared. AwaitingupdateCompleteensures the re-render runs first, making theunlocked_iconbriefly visible before fading out.Generated with Claude Code