Build errors on HP-UX

[dumol]

Hi,

Fellow OpenBSD user here, with access to an Itanium HP-UX 11.31i server. I gave this a try, inspired by your call for HP-UX testing in README.md.

Have tried to build this with both the C and aC++ compilers (the latter can also compile ANSI-C if invoked with -Ae).

Versions used:

$ cc -V
cc: HP C/aC++ B3910B A.06.27 [May 22 2012]
$ aCC -V
aCC: HP C/aC++ B3910B A.06.27 [May 22 2012]

$ ./configure
checking for C compiler... cc
checking if C compiler can compile C99 without -std=c99... yes
checking for -w compiler flag... yes
checking for OS... HP-UX
checking for __dead... no
checking for __dead2... no
checking for asprintf... no
checking for confstr... yes
checking for curses library... curses.h
checking for issetugid... no
checking for pledge... no
checking for reallocarray... no
checking for setresgid... yes
checking for setresuid... yes
checking for sig_t... no
checking for srand_deterministic... no
checking for st_mtim... no
checking for st_mtimespec... no
checking for stravis... no
checking for strlcat... no
checking for strlcpy... no
checking for strtonum... no
checking for strunvis... no
checking for sys_siglist... no
checking for sys_signame... no
checking for timeradd... no
checking for timersub... no
creating Makefile... done
$ make
        cc -DEMACS -DVI -w -c c_sh.c
"c_sh.c", line 735: error #2020: identifier "CLOCK_MONOTONIC" is undefined
        clock_gettime(CLOCK_MONOTONIC, &ts0);
                      ^

1 error detected in the compilation of "c_sh.c".
*** Error exit code 2

Stop.

$ export CC="aCC -Ae"
$ ./configure
checking for C compiler... aCC -Ae
checking if C compiler can compile C99 without -std=c99... yes
checking for -w compiler flag... yes
checking for OS... HP-UX
checking for __dead... no
checking for __dead2... no
checking for asprintf... no
checking for confstr... yes
checking for curses library... curses.h
checking for issetugid... no
checking for pledge... no
checking for reallocarray... no
checking for setresgid... yes
checking for setresuid... yes
checking for sig_t... no
checking for srand_deterministic... no
checking for st_mtim... no
checking for st_mtimespec... no
checking for stravis... no
checking for strlcat... no
checking for strlcpy... no
checking for strtonum... no
checking for strunvis... no
checking for sys_siglist... no
checking for sys_signame... no
checking for timeradd... no
checking for timersub... no
creating Makefile... done
$ make
        aCC -Ae -DEMACS -DVI -w -c alloc.c
        aCC -Ae -DEMACS -DVI -w -c asprintf.c
        aCC -Ae -DEMACS -DVI -w -c c_ksh.c
        aCC -Ae -DEMACS -DVI -w -c c_sh.c
"c_sh.c", line 735: error #2020: identifier "CLOCK_MONOTONIC" is undefined
        clock_gettime(CLOCK_MONOTONIC, &ts0);
                      ^

1 error detected in the compilation of "c_sh.c".
*** Error exit code 2

Stop.

[ibara]

OK. If clock_gettime is an available function but CLOCK_MONOTONIC is not a valid clock_id, then we will have to fall back to CLOCK_REALTIME.

Can you please add the following to portable.h and rebuild and let me know where the next issue is:

#ifndef CLOCK_MONOTONIC
#define CLOCK_MONOTONIC CLOCK_REALTIME
#endif

[dumol]

Thanks for the quick feedback! I'm slower, as this beast is hosted remotely and kept mostly stopped because it's a power hog.

Next issue:

$ make
        cc -DEMACS -DVI -w -c c_sh.c
        cc -DEMACS -DVI -w -c c_test.c
        cc -DEMACS -DVI -w -c c_ulimit.c
        cc -DEMACS -DVI -w -c edit.c
"edit.c", line 182: error #2020: identifier "VDISCARD" is undefined
                cb.c_cc[VDISCARD] = _POSIX_VDISABLE;
                        ^

1 error detected in the compilation of "edit.c".
*** Error exit code 2

Stop.

[ibara]

No problem. We'll get there eventually.
This error is a new one I haven't seen before from other platforms; I'll try to figure out a solution and get back to you.

[ibara]

Looking at what mksh does, it seems like the thing to do is wrap that line, edit.c:182 with

#ifndef __hpux__
cb.c_cc[VDISCARD] = _POSIX_VDISABLE;
#endif

At least for now. We can add a configure check for VDISCARD later.

[dumol]

Same error occurs, as the branching doesn't function as expected, it seems.

I guess it's not the right thing to do, but if I use #ifdef __hpux__ instead, I get past this on HP-UX.

Next error would be:

$ make
        cc -DEMACS -DVI -w -c edit.c
        cc -DEMACS -DVI -w -c emacs.c
        cc -DEMACS -DVI -w -c eval.c
        cc -DEMACS -DVI -w -c exec.c
"exec.c", line 12: error #3696-D: cannot open source file "paths.h"
  #include <paths.h>
                    ^

"exec.c", line 712: error #2020: identifier "_PATH_BSHELL" is undefined
                shell = _PATH_BSHELL;
                        ^

2 errors detected in the compilation of "exec.c".
*** Error exit code 2

Stop.

[ibara]

Ah. That tells me that hpux isn't the right define to detect HPUX. That's fine; I'll make it a more generic check for VDISCARD.

Could you tell me what the default shell is on the machine? Is it /bin/sh? That's what _PATH_BSHELL is looking for.

[ibara]

Though now looking at the code, that definitely needs to change for everyone, so I'll go back to the drawing board :)

[ibara]

OK, after some research...
Can you wrap the #include <paths.h> line in #if 0 like so:

#if 0
#include <paths.h>
#endif

Also, in the file portable.h can you add the following somewhere:

#ifndef _PATH_BSHELL
#define _PATH_BSHELL "/bin/sh"
#endif

[dumol]

Ah. That tells me that hpux isn't the right define to detect HPUX. That's fine; I'll make it a more generic check for VDISCARD.

OK. For now, I'll keep using the stupid define that doesn't break on HP-UX.

Could you tell me what the default shell is on the machine? Is it /bin/sh? That's what _PATH_BSHELL is looking for.

On HP-UX, /bin is linked to /usr/bin, and the default shell is /sbin/sh. Sorry, it actually is:

• /sbin/sh for root and other system users
• /bin/sh for regular users.

[dumol]

OK, after some research...
Can you wrap the #include <paths.h> line in #if 0 like so:

#if 0
#include <paths.h>
#endif

Also, in the file portable.h can you add the following somewhere:

#ifndef _PATH_BSHELL
#define _PATH_BSHELL "/bin/sh"
#endif

With these changes (/bin/sh is actually the default shell for regular users, see correction in my previous comment), I get:

$ make
        cc -DEMACS -DVI -w -c edit.c
        cc -DEMACS -DVI -w -c exec.c
        cc -DEMACS -DVI -w -c expr.c
        cc -DEMACS -DVI -w -c history.c
        cc -DEMACS -DVI -w -c io.c
        cc -DEMACS -DVI -w -c jobs.c
        cc -DEMACS -DVI -w -c lex.c
        cc -DEMACS -DVI -w -c mail.c
        cc -DEMACS -DVI -w -c main.c
"main.c", line 11: error #3696-D: cannot open source file "paths.h"
  #include <paths.h>
                    ^

"main.c", line 111: error #2020: identifier "MAXLOGNAME" is undefined
  char username[_PW_NAME_LEN + 1];
                ^

"main.c", line 202: error #2020: identifier "_PATH_DEFPATH" is undefined
        def_path = _PATH_DEFPATH;
                   ^

3 errors detected in the compilation of "main.c".
*** Error exit code 2

Stop.

I repeat the if 0 trick in main.c and it works, only these remain:

$ make
        cc -DEMACS -DVI -w -c main.c
"main.c", line 113: error #2020: identifier "MAXLOGNAME" is undefined
  char username[_PW_NAME_LEN + 1];
                ^

"main.c", line 204: error #2020: identifier "_PATH_DEFPATH" is undefined
        def_path = _PATH_DEFPATH;
                   ^

2 errors detected in the compilation of "main.c".
*** Error exit code 2

Stop.

[ibara]

_PW_NAME_LEN is the maximum length of a valid username on HP-UX. Do you happen to know what that is?

_PATH_DEFPATH is your default $PATH. Whatever echo $PATH is when you log in should suffice here.

[ibara]

Also can you check to see if you have any of the defines here: https://github.com/ibara/oksh/blob/master/portable.h#L49
That may also shed some light on what to do for HP-UX.

[dumol]

_PW_NAME_LEN is the maximum length of a valid username on HP-UX. Do you happen to know what that is?

By default, only 8 characters are allowed as maximum length for usernames. However, on this particular system, the maximum allowed length has been raised with lugadmin to 256 characters. (We use a buildslave username everywhere.)

_PATH_DEFPATH is your default $PATH. Whatever echo $PATH is when you log in should suffice here.

Sorry, you'll have to spell it out for me, I'm not into C programming.

[dumol]

Also can you check to see if you have any of the defines here: https://github.com/ibara/oksh/blob/master/portable.h#L49
That may also shed some light on what to do for HP-UX.

Sorry, don't know how to check for that.

Also, forgot to say above that the default path for a regular HP-UX user seems to be:

/usr/bin:/usr/ccs/bin:/usr/contrib/bin:/usr/contrib/Q4/bin:/opt/perl/bin:/opt/gvsd/bin:/opt/ipf/bin:/opt/nettladm/bin:/opt/fcms/bin:/opt/wbem/bin:/opt/wbem/sbin:/opt/sas/bin:/opt/wli/bin:/opt/graphics/common/bin:/opt/hpvm/bin:/opt/atok/bin:/usr/bin/X11:/usr/contrib/bin/X11:/opt/sec_mgmt/bastille/bin:/opt/drd/bin:/opt/dsau/bin:/opt/dsau/sbin:/opt/resmon/bin:/opt/firefox:/usr/contrib/kwdb/bin:/opt/prm/bin:/opt/propplus/bin:/opt/caliper/bin:/opt/perl_32/bin:/opt/perl_64/bin:/opt/sfm/bin:/opt/swm/bin:/opt/sec_mgmt/spc/bin:/opt/ssh/bin:/opt/swa/bin:/opt/hpsmh/bin:/opt/thunderbird:/opt/sentinel/bin:/opt/langtools/bin:/opt/gwlm/bin:/opt/aCC/bin

No, it's not a joke. This is what a freshly added user has in the default shell with no home dir. If I use useradd -m, the files from /etc/skel are copied and the home dir gets appended to the path through .profile.

All this should be taken with a grain of salt, I'm not really an HP-UX admin, even though I used to look after a couple of HP-UX servers for a while and still have access to start one of them if needed.

[ibara]

That's... a lot. Let's try this:

In portable.h, at line 55, can you add the following:

#elif defined(__hpux)
#define _PW_NAME_LEN 8

Then at line 93:

#if defined(__hpux)
#define _PATH_DEFPATH "/usr/bin:/usr/ccs/bin:/usr/contrib/bin"
#endif