[SonarCloud] Component.php & FileUploadHelper.php

Author: micszo

src/lib/Browser/Component/Component.php

@@ -23,6 +23,8 @@
 use OAndreyev\Mink\Driver\WebDriver;
 use RuntimeException;
 
+class DevToolsDriverUnavailableException extends \RuntimeException {}
+
 abstract class Component implements ComponentInterface
 {
     /** @var \Ibexa\Behat\Browser\Locator\LocatorCollection */
@@ -79,11 +81,11 @@ protected function getDevToolsDriver(): ChromeDevToolsDriver
         $webDriver = $driver->getWebDriver();
 
         if (null === $webDriver) {
-            throw new RuntimeException('Error happened when accessing the WebDriver');
+            throw new DevToolsDriverUnavailableException('Error happened when accessing the WebDriver');
         }
 
         if (!($webDriver instanceof \Facebook\WebDriver\Remote\RemoteWebDriver)) {
-            throw new RuntimeException('Expected instance of Facebook\\WebDriver\\Remote\\RemoteWebDriver, got ' . (is_object($webDriver) ? get_class($webDriver) : gettype($webDriver)));
+            throw new DevToolsDriverUnavailableException('Expected instance of Facebook\\WebDriver\\Remote\\RemoteWebDriver, got ' . (is_object($webDriver) ? get_class($webDriver) : gettype($webDriver)));
         }
 
         return new ChromeDevToolsDriver($webDriver);

src/lib/Browser/FileUpload/FileUploadHelper.php

@@ -12,6 +12,8 @@
 use Behat\Mink\Session;
 use FriendsOfBehat\SymfonyExtension\Mink\MinkParameters;
 
+class FileReadException extends \RuntimeException {}
+
 class FileUploadHelper
 {
     /** @var \Behat\Mink\Session */
@@ -32,13 +34,13 @@ public function getRemoteFileUploadPath($filename)
         $driver = $this->session->getDriver();
 
         if ($driver instanceof Selenium2Driver) {
-            if (!preg_match('#[\w\\/\.]*\.zip$#', $filename)) {
+            if (!preg_match('#[\w/.]*\.zip$#', $filename)) {
                 throw new \InvalidArgumentException('Zip archive required to upload to remote browser machine.');
             }
 
             $fileContents = file_get_contents($localFile);
             if ($fileContents === false) {
-                throw new \RuntimeException("Failed to read file: $localFile");
+                throw new FileReadException("Failed to read file: $localFile");
             }
 
             return $driver->getWebDriverSession()->file([