test: cleanup and lint for unused arguments in test functions

Author: cpcloud

ibis/backends/athena/tests/conftest.py

@@ -101,7 +101,7 @@ def postload(self, **kw):
         self.connection = self.connect(schema_name=IBIS_ATHENA_TEST_DATABASE, **kw)
 
     @staticmethod
-    def connect(*, tmpdir, worker_id, **kw) -> BaseBackend:
+    def connect(*, tmpdir, worker_id, **kw) -> BaseBackend:  # noqa: ARG004
         return ibis.athena.connect(**CONNECT_ARGS, **kw)
 
     def _remap_column_names(self, table_name: str) -> dict[str, str]:

ibis/backends/bigquery/tests/conftest.py

@@ -64,7 +64,7 @@ def _load_data(self, **_: Any) -> None:
         query.result()
 
     @staticmethod
-    def connect(*, tmpdir, worker_id, **kw) -> Backend:
+    def connect(*, tmpdir, worker_id, **kw) -> Backend:  # noqa: ARG004
         """Connect to the test project and dataset."""
         credentials, default_project_id = google.auth.default(
             scopes=EXTERNAL_DATA_SCOPES

ibis/backends/bigquery/tests/system/test_connect.py

@@ -30,7 +30,7 @@ def test_repeated_project_name(project_id, credentials):
 def test_project_id_different_from_default_credentials(monkeypatch):
     creds = mock.create_autospec(auth.Credentials)
 
-    def mock_credentials(*args, **kwargs):
+    def mock_credentials(*_, **__):
         return creds, "default-project-id"
 
     monkeypatch.setattr(pydata_google_auth, "default", mock_credentials)

ibis/backends/bigquery/tests/system/udf/test_udf_execute.py

@@ -45,7 +45,7 @@ def my_add(a: float, b: float) -> float:
     )
 
 
-def test_udf_with_struct(alltypes, df, snapshot):
+def test_udf_with_struct(alltypes, df):
     @udf.scalar.python
     def my_struct_thing(a: float, b: float) -> dt.Struct(
         {"width": float, "height": float}

ibis/backends/bigquery/tests/unit/udf/test_core.py

@@ -40,7 +40,7 @@ def f():
 
 
 def test_yield(snapshot):
-    def f(a):
+    def f(_):
         yield from [1, 2, 3]
 
     js = compile(f)
@@ -235,7 +235,7 @@ def test_class_with_properties(snapshot):
 
 
 def test_set_to_object(snapshot):
-    def f(a):
+    def f(_):
         x = set()
         y = 1
         x.add(y)
@@ -246,7 +246,7 @@ def f(a):
 
 
 def test_setitem(snapshot):
-    def f(a):
+    def f(_):
         x = {}
         y = "2"
         x[y] = y
@@ -271,7 +271,7 @@ def f(a):
 
 def test_scope_with_while(snapshot):
     def f():
-        class Foo:
+        class _:
             def do_stuff(self):
                 while True:
                     i = 1

ibis/backends/bigquery/tests/unit/udf/test_usage.py

@@ -66,7 +66,7 @@ def my_len(s: str) -> float:
 def test_udf_int64(argument_type, return_type):
     # invalid argument type, valid return type
     @udf.scalar.python(signature=((argument_type,), return_type))
-    def my_func(x):
+    def my_func(_):
         return 1
 
     expr = my_func(None)

ibis/backends/clickhouse/tests/conftest.py

@@ -79,7 +79,11 @@ def postload(self, **kw: Any):
 
     @staticmethod
     def connect(
-        *, tmpdir, worker_id, settings: Mapping[str, Any] | None = None, **kw: Any
+        *,
+        tmpdir,  # noqa: ARG004
+        worker_id,  # noqa: ARG004
+        settings: Mapping[str, Any] | None = None,
+        **kw: Any,
     ):
         if settings is None:
             settings = {}

ibis/backends/clickhouse/tests/test_aggregations.py

@@ -45,48 +45,48 @@ def test_reduction_invalid_where(alltypes, reduction):
     ("func", "pandas_func"),
     [
         (
-            lambda t, cond: t.bool_col.count(),
-            lambda df, cond: df.bool_col.count(),
+            lambda t, _: t.bool_col.count(),
+            lambda df, _: df.bool_col.count(),
         ),
         (
-            lambda t, cond: t.bool_col.approx_nunique(),
-            lambda df, cond: df.bool_col.nunique(),
+            lambda t, _: t.bool_col.approx_nunique(),
+            lambda df, _: df.bool_col.nunique(),
         ),
         (
-            lambda t, cond: t.double_col.sum(),
-            lambda df, cond: df.double_col.sum(),
+            lambda t, _: t.double_col.sum(),
+            lambda df, _: df.double_col.sum(),
         ),
         (
-            lambda t, cond: t.double_col.mean(),
-            lambda df, cond: df.double_col.mean(),
+            lambda t, _: t.double_col.mean(),
+            lambda df, _: df.double_col.mean(),
         ),
         (
-            lambda t, cond: t.int_col.approx_median(),
-            lambda df, cond: df.int_col.median(),
+            lambda t, _: t.int_col.approx_median(),
+            lambda df, _: df.int_col.median(),
         ),
         (
-            lambda t, cond: t.double_col.min(),
-            lambda df, cond: df.double_col.min(),
+            lambda t, _: t.double_col.min(),
+            lambda df, _: df.double_col.min(),
         ),
         (
-            lambda t, cond: t.double_col.max(),
-            lambda df, cond: df.double_col.max(),
+            lambda t, _: t.double_col.max(),
+            lambda df, _: df.double_col.max(),
         ),
         (
-            lambda t, cond: t.double_col.var(),
-            lambda df, cond: df.double_col.var(),
+            lambda t, _: t.double_col.var(),
+            lambda df, _: df.double_col.var(),
         ),
         (
-            lambda t, cond: t.double_col.std(),
-            lambda df, cond: df.double_col.std(),
+            lambda t, _: t.double_col.std(),
+            lambda df, _: df.double_col.std(),
         ),
         (
-            lambda t, cond: t.double_col.var(how="sample"),
-            lambda df, cond: df.double_col.var(ddof=1),
+            lambda t, _: t.double_col.var(how="sample"),
+            lambda df, _: df.double_col.var(ddof=1),
         ),
         (
-            lambda t, cond: t.double_col.std(how="pop"),
-            lambda df, cond: df.double_col.std(ddof=0),
+            lambda t, _: t.double_col.std(how="pop"),
+            lambda df, _: df.double_col.std(ddof=0),
         ),
         (
             lambda t, cond: t.bool_col.count(where=cond),

ibis/backends/clickhouse/tests/test_client.py

@@ -380,13 +380,13 @@ def test_password_with_bracket():
         ibis.clickhouse.connect(host=host, user=user, port=port, password=quoted_pass)
 
 
-def test_from_url(con):
+def test_from_url():
     assert ibis.connect(
         f"clickhouse://{CLICKHOUSE_USER}:{CLICKHOUSE_PASS}@{CLICKHOUSE_HOST}:{CLICKHOUSE_PORT}/{IBIS_TEST_CLICKHOUSE_DB}"
     )
 
 
-def test_from_url_with_kwargs(con):
+def test_from_url_with_kwargs():
     # since explicit kwargs take precedence, this passes, because we're passing
     # `database` explicitly, even though our connection string says to use a
     # random database

ibis/backends/clickhouse/tests/test_functions.py

@@ -78,13 +78,13 @@ def test_timestamp_cast(alltypes, assert_sql):
     assert_sql(result2, "out2.sql")
 
 
-def test_timestamp_now(con, assert_sql):
+def test_timestamp_now(assert_sql):
     expr = ibis.now()
     assert_sql(expr)
 
 
 @pytest.mark.parametrize("unit", ["y", "m", "d", "w", "h", "minute"])
-def test_timestamp_truncate(con, unit, assert_sql):
+def test_timestamp_truncate(unit, assert_sql):
     stamp = ibis.timestamp("2009-05-17 12:34:56")
     expr = stamp.truncate(unit)
     assert_sql(expr)