chore: apply review suggestions

Author: NickCrews

ibis/expr/api.py

@@ -893,11 +893,8 @@ def timestamp(
     is_ymdhms = any(a is not None for a in args[1:])
 
     if is_ymdhms:
-        if timezone is not None:
-            raise NotImplementedError(
-                "Timezone currently not supported when creating a timestamp from components"
-            )
-        return ops.TimestampFromYMDHMS(*args, nullable=nullable).to_expr()
+        dtype = dt.Timestamp(timezone=timezone, nullable=nullable, scale=0)
+        return ops.TimestampFromYMDHMS(*args, dtype=dtype).to_expr()
     elif isinstance(value_or_year, (numbers.Real, ir.IntegerValue)):
         raise TypeError("Use ibis.literal(...).as_timestamp() instead")
     elif isinstance(value_or_year, ir.Expr):
@@ -906,7 +903,7 @@ def timestamp(
         value = normalize_datetime(value_or_year)
         tzinfo = normalize_timezone(timezone or value.tzinfo)
         timezone = tzinfo.tzname(value) if tzinfo is not None else None
-        dtype = dt.Timestamp.from_datetime(value, timezone=timezone, nullable=nullable)
+        dtype = dt.Timestamp.from_datetime(value, nullable=nullable)
         return literal(value, type=dtype)
 
 

ibis/expr/datatypes/core.py

@@ -647,16 +647,16 @@ def from_unit(cls, unit, timezone=None, nullable=True):
         return cls(scale=scale, timezone=timezone, nullable=nullable)
 
     @classmethod
-    def from_datetime(
-        cls, dt: pydatetime.datetime, timezone: str | None = None, nullable: bool = True
-    ):
+    def from_datetime(cls, dt: pydatetime.datetime, *, nullable: bool = True):
         """Infer from a python datetime.datetime object."""
         if dt.microsecond:
             scale = 6
         else:
             scale = 0
-        if timezone is None and dt.tzinfo is not None:
+        if dt.tzinfo is not None:
             timezone = str(dt.tzinfo)
+        else:
+            timezone = None
         return cls(scale=scale, timezone=timezone, nullable=nullable)
 
     @classmethod

ibis/expr/operations/temporal.py

@@ -258,18 +258,10 @@ class TimestampFromYMDHMS(Value):
     hours: Value[dt.Integer]
     minutes: Value[dt.Integer]
     seconds: Value[dt.Integer]
-    nullable: bool = True
 
+    dtype: dt.Timestamp
     shape = rlz.shape_like(["year", "month", "day", "hours", "minutes", "seconds"])
 
-    @attribute
-    def dtype(self):
-        return dt.Timestamp(
-            nullable=self.nullable,
-            timezone=None,
-            scale=0,  # second precision
-        )
-
 
 @public
 class TimestampFromUNIX(Value):