Skip to content

CSS sizing #5

Open
Open
@wkeese

Description

@wkeese

Try to do sizing completely in CSS, rather than in javascript.

Hopefully this can be done by:

  1. Using percentages rather than hardcoded pixel values. The exceptions would be

    a. vertical positioning in ColumnView (which is controlled by this.hourSize)
    b. vertical positioning within a row of overlapping events in GridView (which is controlled by font-size or the height a HorizontalRenderer)

  2. Using CSS flex-blox sizing instead of <table> elements. IIUC with flex-box you can set a fixed percentage height for each row/column, regardless of the amount of content in that row/column. And you can still do animation to for that feature of expanding a certain row of the GridView (http://stackoverflow.com/questions/11106876/is-it-possible-to-animate-flexbox-inserts-removes)

Note that widget height changes are handled differently for GridView and ColumnView. The ColumnView maintains the same scrollHeight regardless of the offsetHeight of the widget; there's just more scrolling. Whereas in GridView, each <table> cell and Renderer changes size and position as the widget itself changes size.

Changes in width affect the sizes and positions of elements in both GridView and ColumnView.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions