Fix Stateful#deliver() so that dcl.superCall() works as expected.

In other words, in the code below, computeProperties() and refreshRendering()
should be called *before* the ... code runs:

deliver: dcl.superCall(function (sup) {
	return function () {
		sup.apply(this, arguments);
		...
	};
})

Author: wkeese

.jshintrc

@@ -66,7 +66,7 @@
 	"maxlen": 120,
 	"indent": 4,
 	"maxerr": 250,
-	"predef": [ "require", "define", "intern" ],
+	"predef": [ "require", "define", "intern", "WeakMap" ],
 	"quotmark": "double",
 	"maxcomplexity": 10
 }

Stateful.js

@@ -103,7 +103,7 @@ define([
 					configurable: false,
 					value: proto[prop]
 				});
-				
+
 				// Setup ES5 getter and setter for this property, unless it already has custom ones.
 				var descriptor = Object.getOwnPropertyDescriptor(proto, prop);
 				if (!descriptor.set) {
@@ -196,7 +196,7 @@ define([
 		 */
 		_set: function (name, value) {
 			var shadowPropName = propNames(name).s;
-			
+
 			// Add the shadow property to the instance, masking what's in the prototype.
 			// Use Object.defineProperty() so it's hidden from for(var key in ...) and Object.keys().
 			Object.defineProperty(this, shadowPropName, {
@@ -278,8 +278,8 @@ define([
 				advise.after(this, "_notify", function (args) {
 					h.notify(args[0], args[1]);
 				}),
-				advise.after(this, "deliver", h.deliver.bind(h)),
-				advise.after(this, "discardChanges", h.discardChanges.bind(h))
+				advise.after(this, "_deliver", h.deliver.bind(h)),
+				advise.after(this, "_discardChanges", h.discardChanges.bind(h))
 			];
 
 			return {
@@ -306,16 +306,32 @@ define([
 		_notify: function () {
 		},
 
+		/**
+		 * Don't call this directly, it's a hook-point to register calls to Notifier#deliver().
+		 * @private
+		 */
+		_deliver: function () {
+		},
+
+		/**
+		 * Don't call this directly, it's a hook-point to register calls to Notifier#discardChanges().
+		 * @private
+		 */
+		_discardChanges: function () {
+		},
+
 		/**
 		 * Synchronously deliver change records to all listeners registered via `observe()`.
 		 */
 		deliver: function () {
+			this._deliver();
 		},
 
 		/**
 		 * Discard change records for all listeners registered via `observe()`.
 		 */
 		discardChanges: function () {
+			this._discardChanges();
 		}
 	}, {
 		enumerable: false

tests/unit/Stateful.js

@@ -387,6 +387,38 @@ define(function (require) {
 			}), 10);
 		},
 
+		"overriding Stateful#deliver()": function () {
+			var log = [];
+			var MyStateful = dcl(Stateful, {
+				// Properties.
+				foo: undefined,
+				bar: undefined,
+
+				// Override Stateful#deliver() to test that sup.apply() calls observe() callbacks.
+				deliver: dcl.superCall(function (sup) {
+					return function () {
+						log.push("deliver before");
+						sup.apply(this, arguments);
+						log.push("deliver after");
+					};
+				})
+			});
+			var stateful = new MyStateful({
+				foo: "Foo0",
+				bar: "Bar0"
+			});
+			stateful.observe(function () {
+				log.push("observer 1");
+			});
+			stateful.observe(function () {
+				log.push("observer 2");
+			});
+			stateful.foo = "Foo1";
+			stateful.bar = "Bar1";
+			stateful.deliver();
+			assert.deepEqual(log, ["deliver before", "observer 1", "observer 2", "deliver after"], "deliver()");
+		},
+
 		"observe filter": function () {
 			// Check to make sure reported changes are consistent between platforms with and without Object.observe()
 			// native support