Skip to content

Toaster test problems #717

Open
Open
@wkeese

Description

Issues:

  1. The toaster tests are [intermittently] failing in "Check toaster stacking permanent messages", at least on FF on Saucelabs.
  2. The failure error message isn't reported; rather the whole test just times out.

Meta-issues:

  1. The Promise chain doesn't make sense. For example:
.then(pollUntil(codeIns(perm1), [], intern.config.WAIT_TIMEOUT, intern.config.POLL_INTERVAL))
.then(function () {}, function errback1 () { throw new Error("perm1 not inserted"); })
.then(pollUntil(codeIns(exp2000), [], intern.config.WAIT_TIMEOUT, intern.config.POLL_INTERVAL))
.then(function () {}, function errback2 () { throw new Error("exp2000 not inserted"); })

When errback1 throws the error, we want the whole test to abort, but instead the error gets passed to errback2.

  1. The test is overly-complicated due to trying to use dynamic id's. Making the ids (and global variable names) deterministic would mean that the test wouldn't have to query the page to get the ids.

Activity

added a commit that references this issue on Apr 11, 2019
self-assigned this
on Apr 11, 2019
added a commit that references this issue on Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

    Participants

    @wkeese

    Issue actions

      Toaster test problems · Issue #717 · ibm-js/deliteful