Skip to content

Commit f537eb4

Browse files
committed
Add Linux and Windows binaries for electron version 28
1 parent 023f15a commit f537eb4

File tree

2 files changed

+18
-5
lines changed

2 files changed

+18
-5
lines changed

build.zip

-949 KB
Binary file not shown.

installer/driverInstall.js

+18-5
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ var platform = os.platform();
2525
var arch = os.arch();
2626

2727
var vscode_build = false;
28-
var electron_version = '25.8.0';
28+
var electron_version = '28.2.8';
2929
var downloadProgress = 0;
3030
var silentInstallation = false;
3131

@@ -625,7 +625,7 @@ var install_node_ibm_db = function(file_url) {
625625
fileName = "_linux_" + electronVersion[0];
626626
}
627627
odbcBindingsNode = 'build\/Release\/odbc_bindings' + fileName + '.node';
628-
if(electronVersion[0] < 19) {
628+
if(electronVersion[0] < 22) {
629629
console.log("No precompiled electron binary available"+
630630
" for electron " + electron_version + "\n");
631631
process.exit(1);
@@ -642,9 +642,9 @@ var install_node_ibm_db = function(file_url) {
642642
var ODBC_BINDINGS_V15 = 'build\/Release\/odbc_bindings.node.15.14.0';
643643
var ODBC_BINDINGS_V16 = 'build\/Release\/odbc_bindings.node.16.20.2';
644644
var ODBC_BINDINGS_V17 = 'build\/Release\/odbc_bindings.node.17.9.1';
645-
var ODBC_BINDINGS_V18 = 'build\/Release\/odbc_bindings.node.18.18.2';
645+
var ODBC_BINDINGS_V18 = 'build\/Release\/odbc_bindings.node.18.20.2';
646646
var ODBC_BINDINGS_V19 = 'build\/Release\/odbc_bindings.node.19.9.0';
647-
var ODBC_BINDINGS_V20 = 'build\/Release\/odbc_bindings.node.20.9.0';
647+
var ODBC_BINDINGS_V20 = 'build\/Release\/odbc_bindings.node.20.12.2';
648648

649649
// Windows add-on binary for node.js v0.10.x, v0.12.7, 4.x, 6.x, 7.x, 8.x and 9.x has been discontinued.
650650
if(Number(process.version.match(/^v(\d+\.\d+)/)[1]) < 10.0) {
@@ -867,7 +867,19 @@ function findElectronVersion() {
867867
var codeOut = execSync('code --version').toString();
868868
vscodeVer = parseFloat(codeOut.split('\n')[0]);
869869
if(!isNaN(vscodeVer)) {
870-
if (vscodeVer >= 1.82){
870+
if (vscodeVer >= 1.88){
871+
electron_version = "28.2.8";
872+
}
873+
else if (vscodeVer >= 1.86){
874+
electron_version = "27.1.0";
875+
}
876+
else if (vscodeVer >= 1.84){
877+
electron_version = "25.9.2";
878+
}
879+
else if (vscodeVer >= 1.83){
880+
electron_version = "25.8.4";
881+
}
882+
else if (vscodeVer >= 1.82){
871883
electron_version = "25.8.0";
872884
}
873885
else if (vscodeVer >= 1.81){
@@ -896,6 +908,7 @@ function findElectronVersion() {
896908
}
897909
else {// vscode version older than 1.69 not supported
898910
electron_version = "18.3.5";
911+
printMsg("VSCode version " + vscodeVer + " is too old!");
899912
}
900913
printMsg("Detected VSCode version" + vscodeVer +
901914
", will use Electron version " + electron_version);

0 commit comments

Comments
 (0)