Skip to content

Commit cd083ae

Browse files
committed
gh ci: remove -j build flags as it's the default with ninja
1 parent c8a1130 commit cd083ae

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

.github/workflows/unit-test.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@ jobs:
1515
matrix:
1616
cfg:
1717
# ubuntu sanitizing address, undefined, leak, thread
18-
- {name: 'linux gcc dbg s:addr,ub,leak', os: ubuntu-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1 -DSAN_UB=1 -DSAN_LEAK=1', buildflags: '-- -j'}
19-
- {name: 'linux gcc rel s:addr', os: ubuntu-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_ADDR=1', buildflags: '-- -j'}
20-
- {name: 'linux gcc rel s:thread', os: ubuntu-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_THREAD=1', buildflags: '-- -j'}
18+
- {name: 'linux gcc dbg s:addr,ub,leak', os: ubuntu-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1 -DSAN_UB=1 -DSAN_LEAK=1'}
19+
- {name: 'linux gcc rel s:addr', os: ubuntu-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_ADDR=1'}
20+
- {name: 'linux gcc rel s:thread', os: ubuntu-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_THREAD=1'}
2121
# macos - no ub santizer (there are still some apple-specific ub sanitizer issues to fix)
2222
# https://github.com/iboB/dynamix/issues/44
2323
# also no leak sanitizer since it's not supported by apple
24-
- {name: 'mac clang dbg s:addr', os: macos-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1', buildflags: '-- -j'}
25-
- {name: 'mac clang rel s:addr', os: macos-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_ADDR=1', buildflags: '-- -j'}
26-
- {name: 'mac clang rel s:thread', os: macos-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_THREAD=1', buildflags: '-- -j'}
24+
- {name: 'mac clang dbg s:addr', os: macos-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1'}
25+
- {name: 'mac clang rel s:addr', os: macos-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_ADDR=1'}
26+
- {name: 'mac clang rel s:thread', os: macos-latest, btype: RelWithDebInfo, cmakeflags: '-DSAN_THREAD=1'}
2727
# windows: no santizer with RelWithDebInfo (likely a msvc sanitizer bug... working on it)
2828
# https://developercommunity.visualstudio.com/t/Address-sanitizer-in-Release-may-introdu/10314256?port=1025&fsid=c7b0f725-0959-4e2d-b63e-e4711eb92eca
29-
- {name: 'win msvc dbg s:addr', os: windows-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1', buildflags: ''}
30-
- {name: 'win msvc rel', os: windows-latest, btype: RelWithDebInfo, cmakeflags: '', buildflags: ''}
29+
- {name: 'win msvc dbg s:addr', os: windows-latest, btype: Debug, cmakeflags: '-DSAN_ADDR=1'}
30+
- {name: 'win msvc rel', os: windows-latest, btype: RelWithDebInfo, cmakeflags: ''}
3131
defaults:
3232
run:
3333
working-directory: ci
@@ -48,7 +48,7 @@ jobs:
4848
- name: Configure
4949
run: cmake .. -G Ninja -DCMAKE_BUILD_TYPE=${{ matrix.cfg.btype }} ${{ matrix.cfg.cmakeflags }}
5050
- name: Build
51-
run: cmake --build . ${{ matrix.cfg.buildflags }}
51+
run: cmake --build .
5252
- name: Test
5353
run: ctest --output-on-failure
5454
env:

0 commit comments

Comments
 (0)