fix: microscopic errors

Author: iboukhss

src/config/config_builder.cpp

@@ -15,12 +15,10 @@
 
 static void config_error(const std::string& msg, int line = -1)
 {
-    if (line != -1) {
-        throw std::runtime_error(msg + " (line " + itoa(line) + ")");
-    }
-    else {
+    if (line == -1)
         throw std::runtime_error(msg);
-    }
+
+    throw std::runtime_error(msg + " (line " + itoa(line) + ")");
 }
 
 static void expect_argc(const AstNode& node, size_t count)

src/core/client.hpp

@@ -36,9 +36,7 @@ class Client {
 
 private:
     Client::State state_;
-    uint64_t id_;
     int fd_;
-    sockaddr_in addr_;
     std::string send_buffer_;
     HttpParser parser_;
     Handler* handler_;

src/handler/static_file_handler.cpp

@@ -45,10 +45,12 @@ static std::string resolve_path(const std::string& path,
 static const char* derive_file_type(const std::string& file_path)
 {
     size_t pos = file_path.rfind(".");
+
     if (pos == std::string::npos)
         return ("application/octet-stream");
 
     std::string ext = file_path.substr(pos + 1);
+
     if (ext == "html" || ext == "htm")
         return "text/html; charset=UTF-8";
     if (ext == "txt")
@@ -150,4 +152,4 @@ void StaticFileHandler::set_error(const HttpResponse::Status code)
 {
     res_ = HttpResponse::make_error(code, rc_.shared.error_pages, req_);
     out_buf_ = res_.to_string();
-}
+}

src/http/http_response.cpp

@@ -14,6 +14,7 @@
 HttpResponse::HttpResponse(HttpVersion protocol)
     : http_version(protocol),
       code(HttpResponse::kStatusOk),
+      content_length(0),
       is_chunked(false),
       keep_alive(http_version == kHttpVersion1_1)
 {

src/util/itoa.cpp

@@ -1,3 +1,5 @@
+#include "util/string.hpp"
+
 #include <sstream>
 #include <string>
 

tests/config_parser_unittest.cpp

@@ -67,7 +67,7 @@ UTEST(ConfigParserTest, SingleStatement)
     std::vector<AstNode> nodes = parser.parse_tokens();
     ASSERT_EQ(1u, nodes.size());
 
-    const AstNode statement = nodes[0];
+    const AstNode& statement = nodes[0];
     EXPECT_STREQ("listen", statement.name.c_str());
     ASSERT_EQ(1u, statement.args.size());
     EXPECT_STREQ("8080", statement.args[0].c_str());
@@ -86,7 +86,7 @@ UTEST(ConfigParserTest, SingleBlock)
     std::vector<AstNode> nodes = parser.parse_tokens();
     ASSERT_EQ(1u, nodes.size());
 
-    const AstNode block = nodes[0];
+    const AstNode& block = nodes[0];
     EXPECT_STREQ("server", block.name.c_str());
     ASSERT_EQ(0u, block.args.size());
     ASSERT_EQ(0u, block.children.size());
@@ -108,13 +108,13 @@ UTEST(ConfigParserTest, NestedBlockAndStatement)
     std::vector<AstNode> nodes = parser.parse_tokens();
     ASSERT_EQ(1u, nodes.size());
 
-    const AstNode block = nodes[0];
+    const AstNode& block = nodes[0];
     EXPECT_STREQ("server", block.name.c_str());
     ASSERT_EQ(0u, block.args.size());
     ASSERT_EQ(1u, block.children.size());
     EXPECT_EQ(1, block.line);
 
-    const AstNode statement = block.children[0];
+    const AstNode& statement = block.children[0];
     EXPECT_STREQ("listen", statement.name.c_str());
     ASSERT_EQ(1u, statement.args.size());
     EXPECT_STREQ("8080", statement.args[0].c_str());