ci: update workflow

Author: iboukhss

.clang-tidy

@@ -1,23 +1,38 @@
-Checks: '-*,readability-identifier-naming'
+Checks:
+  - '-*'
+  - 'readability-identifier-naming'
+  - 'cppcoreguidelines-special-member-functions'
+  - 'google-explicit-constructor'
 
-# CamelCase classes, types, structs and enums
 CheckOptions:
+  # CamelCase classes, types, structs and enums
   - key: readability-identifier-naming.ClassCase
     value: CamelCase
+  - key: readability-identifier-naming.TypedefCase
+    value: CamelCase
   - key: readability-identifier-naming.EnumCase
     value: CamelCase
   - key: readability-identifier-naming.StructCase
     value: CamelCase
 
-# snake_case functions and variables
+  # lower_case functions and variables
   - key: readability-identifier-naming.FunctionCase
     value: lower_case
   - key: readability-identifier-naming.VariableCase
     value: lower_case
 
-# underscore suffix for private members (foo_)
+  # Underscore suffix for private members (foo_)
   - key: readability-identifier-naming.PrivateMemberSuffix
     value: _
 
-  - key: readability-identifier-naming.MacroCase
-    value: UPPER_CASE
+  # camelBack constants with k prefix (kMaxConnections)
+  - key: readability-identifier-naming.ConstantCase
+    value: camelBack
+  - key: readability-identifier-naming.ConstantPrefix
+    value: k
+
+  # Rule of three / orthodox cannonical form
+  - key: cppcoreguidelines-special-member-functions.AllowMissingMoveFunctions
+    value: true
+  - key: cppcoreguidelines-special-member-functions.AllowImplicitlyDeletedCopyOrMove
+    value: true

.github/workflows/ci.yml

@@ -0,0 +1,24 @@
+name: CI pipeline
+
+on:
+  pull_request:
+    branches: [main, dev]
+
+jobs:
+  ci:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: pipx install compiledb
+
+      - name: Run clang-format
+        run: clang-format --dry-run --Werror *.cpp *.hpp
+
+      - name: Build and generate compilation database
+        run: compiledb make
+
+      - name: Run clang-tidy
+        run: clang-tidy --header-filter=.* --warnings-as-errors=* *.cpp

Client.hpp

@@ -7,9 +7,14 @@
 
 class Client {
 public:
-    Client(Socket* socket);
+    explicit Client(Socket* socket);
     ~Client();
 
+private:
+    Client();
+    Client(const Client& other);
+    Client& operator=(const Client& other);
+
 private:
     Socket* socket_;
 };

Makefile

@@ -34,10 +34,10 @@ db:
 	compiledb -n $(MAKE)
 
 format:
-	clang-format --style=file --dry-run *.cpp *.hpp
+	clang-format -style=file -dry-run *.cpp *.hpp
 
 format-fix:
-	clang-format --style=file -i *.cpp *.hpp
+	clang-format -style=file -i *.cpp *.hpp
 
 lint:
 	clang-tidy -p=. -header-filter=.* *.cpp

Server.cpp

@@ -51,7 +51,7 @@ void Server::run()
         // poll for available connections
         // two solutions possible : wait returns n events -> either loop 0 to n in the epoll_event
         // array held by the epoll object or modify the wait function to return an array
-        int n_events = epoll_wait(epoll_fd_, events_, MAX_EVENTS, -1);
+        int n_events = epoll_wait(epoll_fd_, events_, WEBSERV_MAX_EVENTS, -1);
 
         for (int i = 0; i < n_events; ++i) {
             int event_fd = events_[i].data.fd;

Server.hpp

@@ -14,7 +14,7 @@
 
 #include <map>
 
-#define MAX_EVENTS 10
+#define WEBSERV_MAX_EVENTS 10
 
 class Server {
 public:
@@ -29,11 +29,13 @@ class Server {
 
 private:
     Server();
+    Server(const Server& other);
+    Server& operator=(const Server& other);
 
 private:
     Socket socket_;
     int epoll_fd_;
-    epoll_event events_[MAX_EVENTS];
+    epoll_event events_[WEBSERV_MAX_EVENTS];
     std::map<int, Client*> clients_; // Map of clients connections
 };
 

Socket.hpp

@@ -21,6 +21,10 @@ class Socket {
 
     int fd() const { return fd_; }
 
+private:
+    Socket(const Socket& other);
+    Socket& operator=(const Socket& other);
+
 private:
     int fd_;
     sockaddr_in addr_;