Skip to content

Commit 355bc4f

Browse files
authored
Closes #719
2 parents 18031ba + 8b5ed22 commit 355bc4f

File tree

13 files changed

+17
-38
lines changed

13 files changed

+17
-38
lines changed

releasenotes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Released on xx/xx/xxxx.
88

99
- Update heat pump documentation to BESTEST Hydronic Heat Pump testcase. This is for [#704](https://github.com/ibpsa/project1-boptest/issues/704).
1010
- Enable BACnet interface to work with test case ``multizone_hydronic_simple_hydronic`` by creating the ``bacnet.ttl``. This is for [#735](https://github.com/ibpsa/project1-boptest/issues/735).
11+
- Remove the ``scenario`` field from the test case ``config.json``. This is for [#719](https://github.com/ibpsa/project1-boptest/issues/719).
1112

1213
**The following changes are not backwards-compatible and significantly change benchmark results:**
1314

testcase.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@ def __init__(self, fmupath='models/wrapped.fmu'):
9090
# Initialize test case
9191
self.initialize(self.config_json['start_time'], self.config_json['warmup_period'])
9292
# Set default scenario
93-
self.set_scenario(self.config_json['scenario'])
93+
scenario_default = {'electricity_price':'constant',
94+
'time_period': None}
95+
self.set_scenario(scenario_default)
9496

9597
def __initilize_data(self):
9698
'''Initializes objects for simulation data storage.

testcases/bestest_air/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 48.0,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/bestest_hydronic/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 48.0,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/bestest_hydronic_heat_pump/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 192.0,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/multizone_office_simple_air/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 1662.66,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/multizone_office_simple_hydronic/models/config.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,5 @@
33
"area" : 5000,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"horizon" : 86400.0,
8-
"interval" : 3600.0,
9-
"scenario" : {"electricity_price":"constant",
10-
"time_period":null}
6+
"step" : 3600.0
117
}

testcases/multizone_residential_hydronic/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 81.08,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/singlezone_commercial_hydronic/models/config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"area" : 8500.0,
44
"start_time" : 0.0,
55
"warmup_period" : 0.0,
6-
"step" : 3600.0,
7-
"scenario" : {"electricity_price":"constant",
8-
"time_period":null}
6+
"step" : 3600.0
97
}

testcases/testcase1/models/config.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@
22
"area" : 10.0,
33
"start_time" : 0.0,
44
"warmup_period" : 0.0,
5-
"step" : 60.0,
6-
"scenario" : {"electricity_price":"constant",
7-
"time_period":null}}
5+
"step" : 60.0
6+
}

0 commit comments

Comments
 (0)