Talking about documentation, translation, etc

[ibra-kdbra]

I have alot of packaging I need to do, plus translation, plus configuring some stuff.

[ibra-kdbra]

@susalulmumaO12
I think the UX idea you pointed. didn't occur on my mind, so let's stick with your idea..

[ibra-kdbra]

Is this right?

(日本語, Nihongo, [ɲihoŋɡo]) for Japanese script?

[ibra-kdbra]

the full block code of xml:

<message>
        <location filename="../src/window.cpp" line="158"/>
        <source>[en] English</source>
        <translation type="unfinished">[en] English</translation>
    </message>
    <message>
        <location filename="../src/window.cpp" line="159"/>
        <source>[es] Español</source>
        <translation type="unfinished">[es] Español</translation>
    </message>
    <message>
        <location filename="../src/window.cpp" line="160"/>
        <source>[fr] French</source>
        <translation type="unfinished">[fr] Français</translation>
    </message>
    <message>
        <location filename="../src/window.cpp" line="161"/>
        <source>[ja] Japenese</source>
        <translation type="unfinished">[ja] 日本語</translation>
    </message>
    <message>
        <location filename="../src/window.cpp" line="162"/>
        <source>[ar] Arabic</source>
        <translation type="unfinished">[ar] العربية</translation>
    </message>

[susalulmumaO12]

Yes, that is correct.

I think the Spanish should look like this?

 <message>
        <location filename="../src/window.cpp" line="159"/>
        <source>[es] Spanish</source>
        <translation type="unfinished">[es] Español</translation>
    </message>

[ibra-kdbra]

k

[ibra-kdbra]

Question; can you give me a screenshot of the GUI when running GenXPassword, and with only english and japenese? for a styling purpose and text purpose.

[susalulmumaO12]

Sure.
English:

Japanese:

Note: Japanese mixed with English somehow displays text in RTL paragraph configuration についてGenXPassword while is should be GenXPasswordについて, it has been confirmed to be in the right order in the translation file

I have found this on topic.

Does it not look the same on other machines?

[susalulmumaO12]

I just realized that in "About" button in menu, "GenXPassword" is appended behind the scenes and not hard coded in neither the source text nor the translation text. (I thought it was only "About"

But I had included "GenXPassword" in the Japanese version so it'd become "GenXPassword について GenXPassword", first one is from ja.ts file, second is from %1.

Which means text direction was not the problem but the order of the words is, what is the convention here?

Screenshots above are from main branch

[ibra-kdbra]

Ouh,you can remove of them 😁.

[ibra-kdbra]

I didn't find any fix for that '&', it's killing my eyes, I will delay the fix, until I find a solution.

[susalulmumaO12]

Yeah I will remove GenXPassword from About line in ja.ts, but it'll still display in the wrong order because Japanese is just... not like anything else hehe, I'll drop any solution I find for anything here.

Everything will be figured out eventually, it just needs time. :)

[ibra-kdbra]

Hehe, thanks for the support, we need to see more from Brainy-Warrior.

[susalulmumaO12]

I forgot to mention the source of some of the changes made on ja.ts.

I read this article and this article, on "how to create a password", that way the translators familiarize themselves with the terms by seeing what the folk uses, for example: translating "special symbols" differs in dictionaries, while we can find multiple translations labeled as "computer term", choosing the friendliest one is what matters, the one used by normal people.

And that about sums it up.

[ibra-kdbra]

Great.

Can be used for other things..

[susalulmumaO12]

Topic: GenXPassword "leading ampersand" bug

TL;DR: not solved.

The bug has been bugging me so I wanted to inspect what's going on, I will list the results of my inspection below.

1. Hard coding switchButton text in passwordgenrator.cpp:

    // passwordgenerator.cpp line 39
    numericSwitch = new SwitchButton("Numeric characters", currentIndexTheme);
    symbolsSwitch = new SwitchButton(QObject::tr("Symbols characters"), currentIndexTheme);

Result: same as before.

2. Changing the language:

I noticed that using any language based on Latin script will also have a leading Ampersand &, like Spanish, I even edited the Japanese file intentionally to narrow down the problem:

    /* ja.ts line 30 */
    <message>
        <location filename="../src/passwordgenerator.cpp" line="39"/>
        <location filename="../src/passwordgenerator.cpp" line="44"/>
        <source>Numeric characters</source>
        <translation>numeric</translation>
    </message>
    <message>
        <location filename="../src/passwordgenerator.cpp" line="40"/>
        <source>Symbols characters</source>
        <translation>記号</translation>
    </message>

Yes, the affected part is only the Latin text.

3. Hard coding the text in the class, and I saw a weird result:

// switchButton.cpp line 56
SwitchButton::SwitchButton(const QString &text, QWidget *const parent)
    : SwitchButton{ parent }
{
    setText("test");
}

Not sure how this happened, or why, but I'm sure that I'm no exactly closer to the solution.

I searched everywhere for similar problems, only thing I found is this not so similar thing, their problem was in setStyle anyway.

Case is not yet closed, investigation continues....

Edit:

I found this, which is much closer to our problem, and it makes total sense to why the text in the second image is the way it is, it states this:

The most likely reason is that Qt automatically makes the first (non-special) character of a string set as the label in a QCheckBox the shortcut character

So basically what needs to be done is to disable automatically setting shortcuts idk how, if this has already been stated by you, then I learned a thing or two through this, when I started I had 0 knowledge on qt so maybe you already knew this.

[ibra-kdbra]

Thanks for the feedback.

I noticed the problem, didn't fix it right away, but had some strings to the fix, I found encountering with the leading ampersand (&) in the text of SwitchButton is due to Qt interpreting the first non-special character as a mnemonic (shortcut) character. This behavior is typical for Qt widgets derived from QAbstractButton, such as QPushButton and QCheckBox, where an ampersand is used to denote keyboard shortcuts (e.g., &File makes F the shortcut key).

Since SwitchButton class inherits from QAbstractButton and manually handles text rendering in the paintEvent, Qt is still processing the text for mnemonics, which results in the unintended leading ampersand appearing in the UI.

I fixed it eventually, but didn't try it, thanks for remembering me about this Bug.

[susalulmumaO12]

I understand how the ampersand works, but didn't think it'd be automatically put there by Qt.

I fixed it eventually, but didn't try it

Ok I hope your solutions works out.

thanks for remembering me about this Bug.

Anytime 🫡🫡

[ibra-kdbra]

Fixed.

[susalulmumaO12]

That was fast

[ibra-kdbra]

Flash is in the way.

[ibra-kdbra]

Done, the project is nearly finished.

• Installation script for multiple OS
• Translation for 5 different languages
• fixed most of the bugs
• Tray display for better usability( when clicking x button the app will be minimized into the desktop bar.

[susalulmumaO12]

So, in result, every other feature now works, just not the translation, idk if it's a good deal.

but we can fix it

after installation.

so if you run it from the build folder it works?

[susalulmumaO12]

well, I just tested it, from ./bin/build/ folder, it works, but restarting now is a pain, the process takes long time in the background to terminate, got some errors on that.

not sure if the Spanish translation is supposed to be done, but it doesn't look like it:

[susalulmumaO12]

one more thing, we should make a table of the shortcuts, as they're not present in all translations.

for example "cut password" shortcut seems to exist in Spanish, while it does not in Japanese, even if we don't make them unified (which I think there should be a standard for shortcuts in applications), just at least make sure a shortcut exists for every translation

[ibra-kdbra]

okay make the tables of shortcuts in Japanese.

[susalulmumaO12]

Roger.

[ibra-kdbra]

No the install-scripts works like this:

sudo ./install-scripts/install.sh install/uninstall

then it can be a normal application in you OS, you can find it in /opt/ directory, run it from the start menu for easiness.

[ibra-kdbra]

The quitting terminal process job is a headache for now, as In qt it should b easier, I will inspect this.

[susalulmumaO12]

Yes I am aware of that, but I suggested that as a debugging step, to narrow down the problem to why it cannot find the translation files.

[ibra-kdbra]

Well, that's for the weekend on Friday.

[susalulmumaO12]

done:

Ja Shortcut	Description
&L	Languages
-	Restart now
-	Restart later
&T	Themes
-	Light
-	Dark
&S	Shortcuts
&G	Generate password
-	Cut password
&C	Copy password
&C	Custom title bar
&H	Help
&A	About GenXPassword
&C	Credits
&Q	About Qt
&X	Exit

Warning

Abort button has not been translated.

And in "About" section, there are still these: {1>?} {1?} {2

[ibra-kdbra]

Well done, you can fix the other problems.

[susalulmumaO12]

Please specify other problems.

[ibra-kdbra]

The other unused characters you provided above.

[susalulmumaO12]

Ok I'll lookup what the English version has and take that as a base.

[ibra-kdbra]

Big Clap 👏🏽

[susalulmumaO12]

Good evening,

I need your assistance on Design Patterns documentation.
Thank you

[susalulmumaO12]

Overview section, and "Requirements and Build" section.

Thank you, (Yes, I am aware of that, I'm studying smh, design patterns is a part of this studying thing)

[ibra-kdbra]

You don't need design patterns in you studying.

Even if you know the lecture, the implementation is quiet a hassle.

[susalulmumaO12]

I did not implement it, I just looked at it.

[ibra-kdbra]

Ok.

Don't make it hard yourself, if you can't understand too much, leave it, or ask about the missing info.

[susalulmumaO12]

Exactly what I did :)