Skip to content

Commit 32b7d9e

Browse files
committed
Apply debouncing pattern to more GET
1 parent 0ee100b commit 32b7d9e

File tree

7 files changed

+27
-12
lines changed

7 files changed

+27
-12
lines changed

frontend/src/components/classify-failures.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,10 @@ const ClassifyFailuresTable = () => {
122122
}
123123
};
124124

125-
fetchData();
125+
const debouncer = setTimeout(() => {
126+
fetchData();
127+
}, 150);
128+
return () => clearTimeout(debouncer);
126129
}, [
127130
page,
128131
pageSize,

frontend/src/components/test-history.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ const TestHistoryTable = ({ comparisonResults, testResult }) => {
175175
} else {
176176
const debouncer = setTimeout(() => {
177177
getResults();
178-
}, 200);
178+
}, 150);
179179
return () => {
180180
clearTimeout(debouncer);
181181
};
@@ -240,7 +240,7 @@ const TestHistoryTable = ({ comparisonResults, testResult }) => {
240240
};
241241
const debouncer = setTimeout(() => {
242242
resultAggFetch();
243-
}, 200);
243+
}, 150);
244244
return () => {
245245
clearTimeout(debouncer);
246246
};

frontend/src/dashboard.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,10 @@ const Dashboard = () => {
146146
};
147147

148148
if (primaryObject) {
149-
fetchDashboards();
149+
const debouncer = setTimeout(() => {
150+
fetchDashboards();
151+
}, 150);
152+
return () => clearTimeout(debouncer);
150153
}
151154

152155
// eslint-disable-next-line react-hooks/exhaustive-deps

frontend/src/pages/admin/user-list.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,10 @@ const UserList = () => {
8282
}
8383
};
8484

85-
fetchUsers();
85+
const debouncer = setTimeout(() => {
86+
fetchUsers();
87+
}, 150);
88+
return () => clearTimeout(debouncer);
8689
}, [
8790
page,
8891
pageSize,
@@ -113,7 +116,10 @@ const UserList = () => {
113116
}
114117
}
115118
};
116-
deleteCall();
119+
const debouncer = setTimeout(() => {
120+
deleteCall();
121+
}, 150);
122+
return () => clearTimeout(debouncer);
117123
}, [selectedUser]);
118124

119125
useEffect(() => {

frontend/src/result-list.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ const ResultList = () => {
7474

7575
const debouncer = setTimeout(() => {
7676
fetchData();
77-
}, 200);
77+
}, 150);
7878
return () => clearTimeout(debouncer);
7979
}, [
8080
activeFilters,

frontend/src/result.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ const Result = () => {
2424

2525
useEffect(() => {
2626
const fetchTestResult = async () => {
27-
if (!result_id) {
28-
return;
29-
} else if (result_id !== testResult?.id) {
27+
if (result_id !== testResult?.id) {
3028
try {
3129
setFetching(true);
3230
const response = await HttpClient.get([
@@ -45,7 +43,12 @@ const Result = () => {
4543
}
4644
}
4745
};
48-
fetchTestResult();
46+
if (result_id) {
47+
const debouncer = setTimeout(() => {
48+
fetchTestResult();
49+
}, 150);
50+
return () => clearTimeout(debouncer);
51+
}
4952
}, [result_id, testResult]);
5053

5154
return (

frontend/src/run-list.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const RunList = () => {
7373

7474
const debouncer = setTimeout(() => {
7575
fetchData();
76-
}, 200);
76+
}, 150);
7777
return () => clearTimeout(debouncer);
7878
}, [
7979
pageSize,

0 commit comments

Comments
 (0)